Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/perf/page_sets/gmail_expand_collapse_conversation.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/gmail_compose_discard.py ('k') | tools/perf/page_sets/image_decoding_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/gmail_expand_collapse_conversation.py
diff --git a/tools/perf/page_sets/gmail_expand_collapse_conversation.py b/tools/perf/page_sets/gmail_expand_collapse_conversation.py
index 2bfd8604e16c75ec4c17b02aaddf0788b1e11da1..f223e654d794fec0f978e1feaee20536eeba0875 100644
--- a/tools/perf/page_sets/gmail_expand_collapse_conversation.py
+++ b/tools/perf/page_sets/gmail_expand_collapse_conversation.py
@@ -25,48 +25,32 @@ class GmailExpandCollapseConversationPage(
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'condition': 'element',
- 'selector': 'img[alt="Expand all"]'
- }))
+ action_runner.WaitForElement('img[alt="Expand all"]')
action_runner.RunAction(ClickElementAction(
{
'selector': 'img[alt="Expand all"]'
}))
- action_runner.RunAction(WaitAction({'seconds': 5}))
- action_runner.RunAction(WaitAction(
- {
- 'condition': 'element',
- 'selector': 'img[alt="Collapse all"]'
- }))
+ action_runner.Wait(5)
+ action_runner.WaitForElement('img[alt="Collapse all"]')
action_runner.RunAction(ClickElementAction(
{
'selector': 'img[alt="Collapse all"]'
}))
- action_runner.RunAction(WaitAction({'seconds': 1}))
+ action_runner.Wait(1)
def RunEndure(self, action_runner):
- action_runner.RunAction(WaitAction(
- {
- 'condition': 'element',
- 'selector': 'img[alt="Expand all"]'
- }))
+ action_runner.WaitForElement('img[alt="Expand all"]')
action_runner.RunAction(ClickElementAction(
{
'selector': 'img[alt="Expand all"]'
}))
- action_runner.RunAction(WaitAction({'seconds': 1}))
- action_runner.RunAction(WaitAction(
- {
- 'condition': 'element',
- 'selector': 'img[alt="Collapse all"]'
- }))
+ action_runner.Wait(1)
+ action_runner.WaitForElement('img[alt="Collapse all"]')
action_runner.RunAction(ClickElementAction(
{
'selector': 'img[alt="Collapse all"]'
}))
- action_runner.RunAction(WaitAction({'seconds': 1}))
+ action_runner.Wait(1)
class GmailExpandCollapseConversationPageSet(page_set_module.PageSet):
« no previous file with comments | « tools/perf/page_sets/gmail_compose_discard.py ('k') | tools/perf/page_sets/image_decoding_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698