Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: tools/perf/page_sets/gmail_alt_threadlist_conversation.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/calendar_forward_backward.py ('k') | tools/perf/page_sets/gmail_alt_two_labels.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/gmail_alt_threadlist_conversation.py
diff --git a/tools/perf/page_sets/gmail_alt_threadlist_conversation.py b/tools/perf/page_sets/gmail_alt_threadlist_conversation.py
index 152ffc09815965eb0e3b692f22ce42f04273e4d1..5e1c53641c29e6d99032e88cfee393f825418595 100644
--- a/tools/perf/page_sets/gmail_alt_threadlist_conversation.py
+++ b/tools/perf/page_sets/gmail_alt_threadlist_conversation.py
@@ -24,11 +24,9 @@ class GmailAltThreadlistConversationPage(
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'javascript':
- 'window.gmonkey !== undefined && document.getElementById("gb") !== null'
- }))
+ action_runner.WaitForJavaScriptCondition(
+ 'window.gmonkey !== undefined && '
+ 'document.getElementById("gb") !== null')
def RunEndure(self, action_runner):
action_runner.RunAction(ClickElementAction(
@@ -36,13 +34,13 @@ class GmailAltThreadlistConversationPage(
'xpath': '//span[@email]',
'wait_until': {'condition': 'href_change'}
}))
- action_runner.RunAction(WaitAction({'seconds': 1}))
+ action_runner.Wait(1)
action_runner.RunAction(ClickElementAction(
{
'wait_until': {'condition': 'href_change'},
'selector': 'a[href="https://mail.google.com/mail/u/0/?shva=1#inbox"]'
}))
- action_runner.RunAction(WaitAction({'seconds': 1}))
+ action_runner.Wait(1)
class GmailAltThreadlistConversationPageSet(page_set_module.PageSet):
« no previous file with comments | « tools/perf/page_sets/calendar_forward_backward.py ('k') | tools/perf/page_sets/gmail_alt_two_labels.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698