content/test/gpu/page_sets/pixel_tests.py - Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/page_sets/pixel_tests.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing to head. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/gpu/page_sets/pixel_tests.py

diff --git a/content/test/gpu/page_sets/pixel_tests.py b/content/test/gpu/page_sets/pixel_tests.py

index 7d6e33ff009adb4ae6910bcbf9f122a25c5fa249..720af302e43017b39835dcf15fd8b933b2a757be 100644

--- a/content/test/gpu/page_sets/pixel_tests.py

+++ b/content/test/gpu/page_sets/pixel_tests.py

@@ -17,11 +17,8 @@ class PixelTestsPage(page_module.Page):

def RunNavigateSteps(self, action_runner):

action_runner.NavigateToPage(self)

- action_runner.RunAction(WaitAction(

- {

- 'javascript': 'domAutomationController._finished',

- 'timeout': 30

- }))

+ action_runner.WaitForJavaScriptCondition(

+ 'domAutomationController._finished', timeout=30)

class PixelTestsPageSet(page_set_module.PageSet):

« no previous file with comments | « content/test/gpu/page_sets/memory_tests.py ('k') | tools/perf/benchmarks/maps.py » ('j') | no next file with comments »