Cleanup redundant model_ field in BookmarkBarView.

Cleanup redundant model_ field in BookmarkBarView.

BUG=None
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275677

[Joao da Silva, 2014-06-06 17:29:23]

Here's the cleanup requested in the other CL.

[sky, 2014-06-06 19:49:20]

LGTM

https://codereview.chromium.org/321553004/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/321553004/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:1339: if (client_) {
I'm not sure this ever happens, but I suppose that can be dealt with separately.

https://codereview.chromium.org/321553004/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.h (right):

https://codereview.chromium.org/321553004/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.h:275: BookmarkModel*
model() { return client_->model(); }
nit: move after Init() (I view init similar to a constructor, so prefer it early
on).

[Joao da Silva, 2014-06-06 20:12:19]

https://codereview.chromium.org/321553004/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/321553004/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:1339: if (client_) {
On 2014/06/06 19:49:20, sky wrote:
> I'm not sure this ever happens, but I suppose that can be dealt with
separately.

BookmarkModelFactory::ServiceIsNULLWhileTesting() return true. I'm guessing this
checks for tests that use a TestingProfile but don't call
TestingProfile::CreateBookmarkModel().

https://codereview.chromium.org/321553004/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.h (right):

https://codereview.chromium.org/321553004/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.h:275: BookmarkModel*
model() { return client_->model(); }
On 2014/06/06 19:49:20, sky wrote:
> nit: move after Init() (I view init similar to a constructor, so prefer it
early
> on).

Done.

[Joao da Silva, 2014-06-07 10:53:04]

Committed patchset #4 manually as r275677 (presubmit successful).