Issue 321543004: Rewrite GetPropertyAttribute to use the LookupIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321543004: Rewrite GetPropertyAttribute to use the LookupIterator (Closed)

Created:
6 years, 6 months ago by Toon Verwaest

Modified:
6 years, 6 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Rewrite GetPropertyAttribute to use the LookupIterator BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21814

Patch Set 2 : origin -> root #

Total comments: 1

Patch Set 3 : Addressed comment #

Patch Set 4 : Remove bogus asserts #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -176 lines)			Patch
M	src/api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/contexts.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/lookup.h	View	1 2	4 chunks	+24 lines, -8 lines	0 comments	Download
M	src/lookup.cc	View	1 2 3	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/objects.h	View		4 chunks	+11 lines, -30 lines	0 comments	Download
M	src/objects.cc	View	1 2	9 chunks	+57 lines, -117 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/runtime.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with suggestion: https://codereview.chromium.org/321543004/diff/200001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/321543004/diff/200001/src/objects.cc#newcode570 src/objects.cc:570: it->skip_access_checks(); Naming suggestions: 1) either skip_interceptorS() ...

6 years, 6 months ago (2014-06-12 13:27:54 UTC) #2

Toon Verwaest

6 years, 6 months ago (2014-06-12 15:08:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r21814 (presubmit successful).