chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc - Issue 321533003: Separate PermissionsData::CanExecuteScriptOnPage into two functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

Issue 321533003: Separate PermissionsData::CanExecuteScriptOnPage into two functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_unittest.cc ('k') | chrome/renderer/extensions/renderer_permissions_policy_delegate.h » ('j') | extensions/common/permissions/permissions_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

index d18512fdb08b33d0ca04524d968c070b38f931e0..660830861bba949e795ebe27fd211eef7764016c 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

@@ -34,8 +34,8 @@ TEST_F(ExtensionManifestTest, ChromeURLPermissionAllowedWithFlag) {

LoadAndExpectSuccess("permission_chrome_url_invalid.json");

EXPECT_EQ("", error);

const GURL newtab_url(chrome::kChromeUINewTabURL);

- EXPECT_TRUE(extension->permissions_data()->CanExecuteScriptOnPage(

- extension, newtab_url, newtab_url, 0, NULL, -1, &error))

+ EXPECT_TRUE(extension->permissions_data()->CanAccessPage(

+ extension, newtab_url, newtab_url, 0, -1, &error))

<< error;

}