chrome/browser/extensions/api/web_request/web_request_permissions.cc - Issue 321533003: Separate PermissionsData::CanExecuteScriptOnPage into two functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_permissions.cc

Issue 321533003: Separate PermissionsData::CanExecuteScriptOnPage into two functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/extensions/browser_permissions_policy_delegate.h » ('j') | extensions/common/permissions/permissions_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_permissions.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions.cc b/chrome/browser/extensions/api/web_request/web_request_permissions.cc

index 1617c72fd704c9594da1270c807d49f7ed097838..8cf648dc9204a7d9c41e314f700a087813df2d6c 100644

--- a/chrome/browser/extensions/api/web_request/web_request_permissions.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_permissions.cc

@@ -26,7 +26,7 @@ namespace {

// to check for updates, extension blacklisting, etc.

bool IsSensitiveURL(const GURL& url) {

// TODO(battre) Merge this, CanExtensionAccessURL and

- // PermissionsData::CanExecuteScriptOnPage into one function.

+ // PermissionsData::CanAccessPage into one function.

bool sensitive_chrome_url = false;

const std::string host = url.host();

const char kGoogleCom[] = ".google.com";