Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: Source/devtools/front_end/ResponsiveDesignView.js

Issue 321513004: [DevTools] Limit responsive design resize request to width/height only. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/sdk/OverridesSupport.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ResponsiveDesignView.js
diff --git a/Source/devtools/front_end/ResponsiveDesignView.js b/Source/devtools/front_end/ResponsiveDesignView.js
index d71b517f2739d06d5746ee692302e9f1c1a90093..23b698eb8d3e48a5c843f66659d96245a3e86fc1 100644
--- a/Source/devtools/front_end/ResponsiveDesignView.js
+++ b/Source/devtools/front_end/ResponsiveDesignView.js
@@ -173,7 +173,7 @@ WebInspector.ResponsiveDesignView.prototype = {
var cssOffset = this._slowPositionStart ? (event.data.currentPosition - this._slowPositionStart) / 10 + this._slowPositionStart - event.data.startPosition : event.data.currentPosition - event.data.startPosition;
var dipOffset = Math.round(cssOffset * WebInspector.zoomManager.zoomFactor());
var newSize = Math.max(this._resizeStartSize + dipOffset, 1);
- var requested = new Size(this._dipWidth, this._dipHeight);
+ var requested = new Size(-1, -1);
lushnikov 2014/06/06 13:40:47 This looks like a hack. Given that only one axis c
dgozman 2014/06/06 13:47:32 We have plans for two-dimensional resize aswell, w
if (event.target.isVertical())
requested.height = newSize;
else
« no previous file with comments | « no previous file | Source/devtools/front_end/sdk/OverridesSupport.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698