[DevTools] Limit responsive design resize request to width/height only.

[DevTools] Limit responsive design resize request to width/height only.

Before, if we had not enough space and clipped the page height,
resizing width will also reset height to the clipped size.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175687

[dgozman, 2014-06-06 13:33:00]

Take a look please.

[lushnikov, 2014-06-06 13:40:47]

https://codereview.chromium.org/321513004/diff/1/Source/devtools/front_end/Re...
File Source/devtools/front_end/ResponsiveDesignView.js (right):

https://codereview.chromium.org/321513004/diff/1/Source/devtools/front_end/Re...
Source/devtools/front_end/ResponsiveDesignView.js:176: var requested = new
Size(-1, -1);
This looks like a hack.
Given that only one axis could be actually resized and we don't need dimensions
of the other, we should not use Size here as data for the event.

[dgozman, 2014-06-06 13:47:32]

https://codereview.chromium.org/321513004/diff/1/Source/devtools/front_end/Re...
File Source/devtools/front_end/ResponsiveDesignView.js (right):

https://codereview.chromium.org/321513004/diff/1/Source/devtools/front_end/Re...
Source/devtools/front_end/ResponsiveDesignView.js:176: var requested = new
Size(-1, -1);
On 2014/06/06 13:40:47, lushnikov wrote:
> This looks like a hack.
> Given that only one axis could be actually resized and we don't need
dimensions
> of the other, we should not use Size here as data for the event.

We have plans for two-dimensional resize aswell, which will use the same event.

[dgozman, 2014-06-06 15:37:22]

Changed width/height to be missing if not set. PTAL

[lushnikov, 2014-06-06 16:22:41]

On 2014/06/06 15:37:22, dgozman wrote:
> Changed width/height to be missing if not set. PTAL

Thanks! LGTM

[dgozman, 2014-06-06 16:29:48]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-06-06 16:30:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/321513004/20001

[commit-bot: I haz the power, 2014-06-06 17:30:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7169)

[commit-bot: I haz the power, 2014-06-06 17:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:33:03]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7181)

[dgozman, 2014-06-06 18:29:28]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-06-06 18:30:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/321513004/20001

[commit-bot: I haz the power, 2014-06-06 18:33:36]

Change committed as 175687