Issue 321473003: Elevated install of recovery component (component update part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321473003: Elevated install of recovery component (component update part) (Closed)

Created:
6 years, 6 months ago by xiaoling

Modified:
6 years ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Elevated install of recovery component when needed. First run recovery component as non-elevated. When it finds that elevation is needed, pop up a UI to notify user of UAC prompt. After user consent to the elevation request, run recovery component installer again with elevated privilege. The CL does not have the UI changes. A separate CL (https://codereview.chromium.org/325433002/) is created for that. This CL includes: (1) When elevation is needed to recover, save the installation source for retry, set a flag in preference to indicate that. (2) Provide API for elevated install BUG=381801

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7861 lines, -7142 lines)			Patch
M	chrome/browser/component_updater/component_unpacker.h	View	1 2 3 4 5 6 7 18	3 chunks	+27 lines, -1 line	0 comments	Download
M	chrome/browser/component_updater/component_unpacker.cc	View	1 2 3 4 5 6 7 8 18	6 chunks	+121 lines, -6 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_service.h	View	1 2 3 4 5 6 7 8 9 10 11 12 18	1 chunk	+229 lines, -220 lines	0 comments	Download
M	chrome/browser/component_updater/default_component_installer.h	View	1 2 3 4 5 6 7 8 18	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/default_component_installer.cc	View	1 2 3 4 5 6 7 8 18	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/pepper_flash_component_installer.cc	View	1 2 3 4 5 6 7 8 18	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/pnacl/pnacl_component_installer.h	View	1 2 3 4 5 6 7 8 18	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/pnacl/pnacl_component_installer.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 18	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/recovery_component_installer.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 18 21	1 chunk	+38 lines, -25 lines	0 comments	Download
M	chrome/browser/component_updater/recovery_component_installer.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 21	1 chunk	+495 lines, -176 lines	0 comments	Download
M	chrome/browser/component_updater/swiftshader_component_installer.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	2 chunks	+11 lines, -0 lines	0 comments	Download
A	chrome/browser/component_updater/test/component_unpacker_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 18	1 chunk	+142 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/test/test_installer.h	View	1 2 3 4 5 6 7 8 18	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/test/test_installer.cc	View	1 2 3 4 5 6 7 8 18	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/net/crl_set_fetcher.h	View	1 2 3 4 5 6 7 8 18	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/net/crl_set_fetcher.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_browser_creator.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+3601 lines, -3601 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+820 lines, -818 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+2299 lines, -2295 lines	0 comments	Download
M	components/component_updater/component_updater_paths.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/component_updater/component_updater_paths.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+8 lines, -0 lines	0 comments	Download

Issue 321473003: Elevated install of recovery component (component update part) (Closed)

Description

Patch Set 1 : Initial upload #

Patch Set 2 : Nit #

Patch Set 3 : Fixed build error on non-Windows #

Patch Set 4 : Synced & rebased to trunk #

Patch Set 5 : Merged changes from upstream. #

Patch Set 6 : documentation update and nit #

Patch Set 7 : c #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Patch Set 17 : #

Patch Set 18 : #

Patch Set 19 : #

Patch Set 20 : #

Patch Set 21 : #

Patch Set 22 : #