Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 321473002: Implement enableFastMobileScrolling web api. (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
Reviewers:
tkent, adamk
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, lgombos, maheshkk
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement enableFastMobileScrolling web api. The effort needs to be done in 3 steps: 1. Create the runtime flag interface in blink; 2. Enable the flag for Android from chromium even it does not do anything in blink; 3. Replace compile time guard with runtime flag in blink and remove ENABLE_FAST_MOBILE_SCROLLING in gyp file. This is the 1st set of changes. BUG=381391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175621 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175761

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
c.shu
6 years, 6 months ago (2014-06-05 22:39:57 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-05 22:59:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/321473002/20001
6 years, 6 months ago (2014-06-05 22:59:19 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-06 01:32:21 UTC) #4
commit-bot: I haz the power
Change committed as 175621
6 years, 6 months ago (2014-06-06 02:10:28 UTC) #5
dcheng
A revert of this CL has been created in https://codereview.chromium.org/317313002/ by dcheng@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-06 02:21:19 UTC) #6
c.shu
On 2014/06/06 02:21:19, dcheng wrote: > A revert of this CL has been created in ...
6 years, 6 months ago (2014-06-06 14:36:36 UTC) #7
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-06 17:44:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/321473002/20001
6 years, 6 months ago (2014-06-06 17:45:05 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:46:20 UTC) #10
commit-bot: I haz the power
Could not make sense out of svn commit message.
6 years, 6 months ago (2014-06-06 17:46:21 UTC) #11
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-08 23:30:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/321473002/20001
6 years, 6 months ago (2014-06-08 23:31:12 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-08 23:31:32 UTC) #14
Message was sent while issue was closed.
Change committed as 175761

Powered by Google App Engine
This is Rietveld 408576698