Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: chrome/browser/extensions/chrome_extension_web_contents_observer.cc

Issue 321453003: Mark ChromeViewHostMsg_DetailedConsoleMessageAdded as extensions-only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix build Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/chrome_extension_web_contents_observer.cc
diff --git a/chrome/browser/extensions/chrome_extension_web_contents_observer.cc b/chrome/browser/extensions/chrome_extension_web_contents_observer.cc
index e32f169b070b71fc0995e65573c40205b87cccec..cc310739fecde548e026c8481f42595d0fb21c1a 100644
--- a/chrome/browser/extensions/chrome_extension_web_contents_observer.cc
+++ b/chrome/browser/extensions/chrome_extension_web_contents_observer.cc
@@ -49,12 +49,16 @@ bool ChromeExtensionWebContentsObserver::OnMessageReceived(
bool ChromeExtensionWebContentsObserver::OnMessageReceived(
const IPC::Message& message,
content::RenderFrameHost* render_frame_host) {
+#if defined(ENABLE_EXTENSIONS)
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(ChromeExtensionWebContentsObserver, message)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_DetailedConsoleMessageAdded,
OnDetailedConsoleMessageAdded)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
+#else
+ bool handled = false;
+#endif
return handled;
}
@@ -63,6 +67,7 @@ void ChromeExtensionWebContentsObserver::OnDetailedConsoleMessageAdded(
const base::string16& source,
const StackTrace& stack_trace,
int32 severity_level) {
+#if defined(ENABLE_EXTENSIONS)
if (!IsSourceFromAnExtension(source))
return;
@@ -83,6 +88,7 @@ void ChromeExtensionWebContentsObserver::OnDetailedConsoleMessageAdded(
static_cast<logging::LogSeverity>(severity_level),
render_view_host->GetRoutingID(),
render_view_host->GetProcess()->GetID())));
+#endif
}
void ChromeExtensionWebContentsObserver::OnPostMessage(int port_id,
« no previous file with comments | « no previous file | chrome/browser/extensions/tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698