Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 321443003: Change the media galleries permission dialog to have a suggestions section. (Closed)

Created:
6 years, 6 months ago by vandebo (ex-Chrome)
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Visibility:
Public.

Description

Change the media galleries permission dialog to have a suggestions section. The old organization was an attached and unattached section. With the hint text of when it was last attached this is unnecessary. The suggestions section now has all galleries that the app didn't start with permission for. BUG=359704 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276415

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -44 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_permission_controller.h View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_permission_controller.cc View 1 2 7 chunks +34 lines, -27 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_permission_controller_unittest.cc View 1 2 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
vandebo (ex-Chrome)
This depends on https://codereview.chromium.org/310383004/
6 years, 6 months ago (2014-06-06 00:38:23 UTC) #1
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-06 06:37:16 UTC) #2
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-06 18:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/321443003/20001
6 years, 6 months ago (2014-06-06 18:54:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 22:28:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 23:37:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/39489)
6 years, 6 months ago (2014-06-06 23:37:42 UTC) #7
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-10 17:01:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/321443003/40001
6 years, 6 months ago (2014-06-10 17:05:07 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 01:08:02 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 07:10:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/18808)
6 years, 6 months ago (2014-06-11 07:10:17 UTC) #12
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-11 15:48:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/321443003/40001
6 years, 6 months ago (2014-06-11 15:51:27 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 15:54:19 UTC) #15
Message was sent while issue was closed.
Change committed as 276415

Powered by Google App Engine
This is Rietveld 408576698