Linux: Improve message handling in CrashHandlerHostLinux to prevent file descriptor leaks.

Linux: Improve message handling in CrashHandlerHostLinux to prevent file descriptor leaks.

BUG=373091
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275339

[mdempsky, 2014-06-05 21:53:58]

lgtm with two optional nits

https://codereview.chromium.org/321433003/diff/1/components/breakpad/browser/...
File components/breakpad/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/321433003/diff/1/components/breakpad/browser/...
components/breakpad/browser/crash_handler_host_linux.cc:232: } else {
(Since the above "if" condition ends in a "return;", I'd probably remove the
"else" here and unblock/unindent the following code.)

https://codereview.chromium.org/321433003/diff/1/components/breakpad/browser/...
components/breakpad/browser/crash_handler_host_linux.cc:235: if (fd >= 0) {
You can probably DCHECK this?  The kernel should never give us a negative fd.

[Lei Zhang, 2014-06-05 21:57:23]

https://codereview.chromium.org/321433003/diff/1/components/breakpad/browser/...
File components/breakpad/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/321433003/diff/1/components/breakpad/browser/...
components/breakpad/browser/crash_handler_host_linux.cc:232: } else {
On 2014/06/05 21:53:58, mdempsky wrote:
> (Since the above "if" condition ends in a "return;", I'd probably remove the
> "else" here and unblock/unindent the following code.)

Done.

https://codereview.chromium.org/321433003/diff/1/components/breakpad/browser/...
components/breakpad/browser/crash_handler_host_linux.cc:235: if (fd >= 0) {
On 2014/06/05 21:53:58, mdempsky wrote:
> You can probably DCHECK this?  The kernel should never give us a negative fd.

Done.

[Lei Zhang, 2014-06-05 21:57:27]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:59:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/321433003/20001

[commit-bot: I haz the power, 2014-06-06 02:39:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-06-06 05:24:04]

Change committed as 275339