Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: Source/bindings/v8/V8RecursionScope.cpp

Issue 321433002: IndexedDB: Ensure transactions created in microtasks are deactivated (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/storage/indexeddb/microtasks-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 #include "config.h" 31 #include "config.h"
32 #include "bindings/v8/V8RecursionScope.h" 32 #include "bindings/v8/V8RecursionScope.h"
33 33
34 #include "core/dom/Microtask.h" 34 #include "core/dom/Microtask.h"
35 #include "modules/indexeddb/IDBPendingTransactionMonitor.h" 35 #include "modules/indexeddb/IDBPendingTransactionMonitor.h"
36 36
37 namespace WebCore { 37 namespace WebCore {
38 38
39 void V8RecursionScope::didLeaveScriptContext() 39 void V8RecursionScope::didLeaveScriptContext()
40 { 40 {
41 // FIXME: Instrument any work that takes place when script exits to c++ (e.g . Mutation Observers). 41 // FIXME: Instrument any work that takes place when script exits to c++ (e.g . Mutation Observers).
adamk 2014/06/05 22:20:45 I think this FIXME is super-old and should go away
42 42
43 Microtask::performCheckpoint();
44
43 // Indexed DB requires that transactions are created with an internal |activ e| flag 45 // Indexed DB requires that transactions are created with an internal |activ e| flag
44 // set to true, but the flag becomes false when control returns to the event loop. 46 // set to true, but the flag becomes false when control returns to the event loop.
45 IDBPendingTransactionMonitor::from(m_executionContext).deactivateNewTransact ions(); 47 IDBPendingTransactionMonitor::from(m_executionContext).deactivateNewTransact ions();
46
47 Microtask::performCheckpoint();
48 } 48 }
49 49
50 } // namespace WebCore 50 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/storage/indexeddb/microtasks-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698