IndexedDB: Ensure transactions created in microtasks are deactivated

IndexedDB: Ensure transactions created in microtasks are deactivated

The IDB spec defines that transactions are created 'active' and become
'inactive' when control returns to the event loop. The way this was
implemented, transactions created within microtasks (e.g. Promise
callbacks) were not deactivated.

Flip the order of microtasks and deactivation, and add tests.

BUG=380910
R=adamk@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175600

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175737

[jsbell, 2014-06-05 22:01:53]

adamk@ - PTAL

Makes the IDB tests happy locally, but I just fired off try jobs.

[adamk, 2014-06-05 22:20:46]

lgtm

https://codereview.chromium.org/321433002/diff/1/Source/bindings/v8/V8Recursi...
File Source/bindings/v8/V8RecursionScope.cpp (right):

https://codereview.chromium.org/321433002/diff/1/Source/bindings/v8/V8Recursi...
Source/bindings/v8/V8RecursionScope.cpp:41: // FIXME: Instrument any work that
takes place when script exits to c++ (e.g. Mutation Observers).
I think this FIXME is super-old and should go away.

[jsbell, 2014-06-05 22:37:05]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-06-05 22:38:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/321433002/20001

[commit-bot: I haz the power, 2014-06-05 23:56:54]

Change committed as 175600

[jsbell, 2014-06-06 17:57:20]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:58:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/321433002/40001

[commit-bot: I haz the power, 2014-06-06 20:14:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7216)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10655)

[commit-bot: I haz the power, 2014-06-06 21:06:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 21:06:11]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10659)

[jsbell, 2014-06-06 21:26:51]

On 2014/06/06 21:06:11, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10659)

Failure looks legit, but of course there's no data from it. :P

[jsbell, 2014-06-06 22:16:09]

On 2014/06/06 21:26:51, jsbell wrote:
> Failure looks legit, but of course there's no data from it. :P

Thanks to adamk@ the failure results are here:

https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/10...

>> assert_equals: Failure should be due to inactive transaction expected
"TransactionInactiveError" but got "InvalidStateError"

... and it looks like IDBTransaction::objectStore() is racy, since it only
checks m_state == Finished. That also means the assertion would vary with the
specifics of the test, so removing it.

[jsbell, 2014-06-06 22:16:49]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-06-06 22:17:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/321433002/60001

[commit-bot: I haz the power, 2014-06-06 23:46:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10682)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11081)

[commit-bot: I haz the power, 2014-06-06 23:55:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 23:55:30]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10705)

[jsbell, 2014-06-07 00:06:23]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-06-07 00:06:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/321433002/60001

[commit-bot: I haz the power, 2014-06-07 00:17:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10707)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11104)

[commit-bot: I haz the power, 2014-06-07 00:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-07 00:51:47]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11111)

[jsbell, 2014-06-07 05:25:35]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-06-07 05:26:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/321433002/60001

[commit-bot: I haz the power, 2014-06-07 06:02:15]

Change committed as 175737