Source/core/svg/SVGPathSegListTearOff.h - Issue 321403004: SVG: Items inserted into list should be made a tear-off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGPathSegListTearOff.h

Issue 321403004: SVG: Items inserted into list should be made a tear-off. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add baseline for mac Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/repaint/modify-transferred-listitem-expected.txt ('k') | Source/core/svg/properties/SVGListPropertyTearOffHelper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/SVGPathSegListTearOff.h

diff --git a/Source/core/svg/SVGPathSegListTearOff.h b/Source/core/svg/SVGPathSegListTearOff.h

index f360f34fca57a23e7a83fd95d0238573f0afad1c..da3046188e8292bbd3ca6be365b5af87aee5d7a9 100644

--- a/Source/core/svg/SVGPathSegListTearOff.h

+++ b/Source/core/svg/SVGPathSegListTearOff.h

@@ -31,6 +31,7 @@

#ifndef SVGPathSegListTearOff_h

#define SVGPathSegListTearOff_h

+#include "SVGNames.h"

#include "core/svg/SVGPathSegList.h"

#include "core/svg/properties/SVGListPropertyTearOffHelper.h"

@@ -43,9 +44,12 @@ public:

// FIXME: Currently SVGPathSegitself is a tear-off.

typedef SVGPathSeg ItemTearOffType;

- static PassRefPtr<ItemPropertyType> getValueForInsertionFromTearOff(PassRefPtr<ItemTearOffType> passNewItem)

+ static PassRefPtr<ItemPropertyType> getValueForInsertionFromTearOff(PassRefPtr<ItemTearOffType> passNewItem, SVGElement* contextElement, const QualifiedName& attributeName)

{

- return passNewItem;

+ ASSERT(attributeName == SVGNames::dAttr);

+ RefPtr<ItemTearOffType> newItem = passNewItem;

+ newItem->setContextElement(contextElement);

+ return newItem.release();

}

static PassRefPtr<ItemTearOffType> createTearOff(PassRefPtr<ItemPropertyType> passValue, SVGElement* contextElement, PropertyIsAnimValType, const QualifiedName&)