LayoutTests/svg/dom/modify-inserted-listitem.html - Issue 321403004: SVG: Items inserted into list should be made a tear-off.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/dom/modify-inserted-listitem.html

Issue 321403004: SVG: Items inserted into list should be made a tear-off. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: LayoutTests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/platform/linux/svg/dom/modify-inserted-listitem-expected.png ('k') | LayoutTests/svg/dom/modify-inserted-listitem-expected.txt » ('j') | Source/core/svg/SVGPathSegListTearOff.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg width="100" height="100">

	3 <rect x="10" y="10" width="10" height="10" fill="green"></rect>

	4 <rect id="move" x="10" y="10" width="10" height="10" fill="red"></rect>
	Erik Dahlström (inactive) 2014/06/11 08:22:03 Wouldn't the test be better if the red rect indica Wouldn't the test be better if the red rect indicated the proper position, and the green rect would cover it when moved to the proper place? Essentially: <rect id="ref" x="20" y="30" width="10" height="10" fill="red"></rect> <rect id="move" x="10" y="10" width="10" height="10" fill="green"></rect> kouhei (in TOK) 2014/06/12 04:25:28 Done. Show quoted text On 2014/06/11 08:22:03, Erik Dahlström wrote: > Wouldn't the test be better if the red rect indicated the proper position, and > the green rect would cover it when moved to the proper place? > > Essentially: > > <rect id="ref" x="20" y="30" width="10" height="10" fill="red"></rect> > <rect id="move" x="10" y="10" width="10" height="10" fill="green"></rect> Done.
	5 </svg>

	6 <script>

	7 jsTestIsAsync = true;

	8 enablePixelTesting = true;
	fs 2014/06/11 08:42:23 Could you make this a repaint test instead? (I thi Could you make this a repaint test instead? (I think that should cover the invalidation case sufficiently?) kouhei (in TOK) 2014/06/12 04:25:28 Done. Show quoted text On 2014/06/11 08:42:23, fs wrote: > Could you make this a repaint test instead? (I think that should cover the > invalidation case sufficiently?) Done.
	9 </script>

	10 <script src="../../resources/js-test.js"></script>

	11 <script>

	12 description("Modifying inserted item to a list should trigger invalidation.");

	13

	14 var transform = document.querySelector('svg').createSVGTransform();

	15 transform.matrix.e = 10;

	16 document.querySelector('#move').transform.baseVal.appendItem(transform);

	17

	18 requestAnimationFrame(function() {

	19 transform.matrix.f = 20;

	20 finishJSTest();

	21 });

	22 </script>

OLD	NEW