Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 321403003: Notify font loads via FontLoader (Closed)

Created:
6 years, 6 months ago by Kunihiko Sakamoto
Modified:
6 years, 6 months ago
Reviewers:
dglazkov, bashi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Visibility:
Public.

Description

Notify font loads via FontLoader Before this patch, font load was noticed to CSSFontSelector through the following path: RemoteFontFaceSource -> CSSFontFace -> CSSSegmentedFontFace -> CSSFontSelector However, StyleEngine clears FontFaceCache upon stylesheet changes and reconstruct it lazily, it is possible that CSSSegmentedFontFace is absent when a load is completed. As a result, loaded font is not rendered. This patch fixes the problem by changing the notification path as follows: RemoteFontFaceSource -> FontLoader -> CSSFontSelector. BUG=378238 TEST=fast/css/font-face-css-change-while-loading.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176463

Patch Set 1 : WIP #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -14 lines) Patch
A LayoutTests/fast/css/font-face-css-change-while-loading.html View 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/font-face-css-change-while-loading-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFace.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/FontLoader.h View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M Source/core/css/FontLoader.cpp View 1 2 3 chunks +12 lines, -2 lines 0 comments Download
M Source/core/css/RemoteFontFaceSource.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Kunihiko Sakamoto
6 years, 6 months ago (2014-06-18 06:40:35 UTC) #1
bashi
non-owner LGTM. https://codereview.chromium.org/321403003/diff/60001/Source/core/css/FontLoader.cpp File Source/core/css/FontLoader.cpp (right): https://codereview.chromium.org/321403003/diff/60001/Source/core/css/FontLoader.cpp#newcode75 Source/core/css/FontLoader.cpp:75: void FontLoader::clearResourceFetcher() nit: we might want to ...
6 years, 6 months ago (2014-06-18 07:27:45 UTC) #2
Kunihiko Sakamoto
https://codereview.chromium.org/321403003/diff/60001/Source/core/css/FontLoader.cpp File Source/core/css/FontLoader.cpp (right): https://codereview.chromium.org/321403003/diff/60001/Source/core/css/FontLoader.cpp#newcode75 Source/core/css/FontLoader.cpp:75: void FontLoader::clearResourceFetcher() On 2014/06/18 07:27:45, bashi1 wrote: > nit: ...
6 years, 6 months ago (2014-06-18 08:21:26 UTC) #3
dglazkov
lgtm
6 years, 6 months ago (2014-06-18 14:47:18 UTC) #4
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 6 months ago (2014-06-18 23:44:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/321403003/80001
6 years, 6 months ago (2014-06-18 23:45:43 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 23:49:47 UTC) #7
Message was sent while issue was closed.
Change committed as 176463

Powered by Google App Engine
This is Rietveld 408576698