Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: build/android/adb_install_apk.py

Issue 321403002: Add option device in install apk script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update according to comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_install_apk.py
diff --git a/build/android/adb_install_apk.py b/build/android/adb_install_apk.py
index a91510137925e766cf5166768f78679e7ed51c12..c7432a4b62885477b19452bb16faf2a2b24e0cfe 100755
--- a/build/android/adb_install_apk.py
+++ b/build/android/adb_install_apk.py
@@ -38,6 +38,8 @@ def AddInstallAPKOption(option_parser):
dest='build_type',
help='If set, run test suites under out/Release. '
'Default is env var BUILDTYPE or Debug.')
+ option_parser.add_option('-d', '--device', dest='device',
+ help=('Target device for apk to install on.'))
frankf 2014/06/12 17:25:47 no () required.
def ValidateInstallAPKOption(option_parser, options):
@@ -59,6 +61,13 @@ def main(argv):
raise Exception('Error: Unknown argument:', args[1:])
devices = android_commands.GetAttachedDevices()
+
+ if options.device:
+ if options.device not in devices:
+ raise Exception('Error: %s not in attached devices %s' % (options.device,
+ ','.join(devices)))
+ devices = [options.device]
+
if not devices:
raise Exception('Error: no connected devices')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698