Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 321393002: Updated SSL interstitial strings (Closed)

Created:
6 years, 6 months ago by felt
Modified:
6 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Updated SSL interstitial strings Glen asked for a small tweak to the SSL interstitial strings. BUG=331453 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276619

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.css View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 30 (0 generated)
felt
hi bernhard, another small tweak. PTAL. thx.
6 years, 6 months ago (2014-06-11 06:42:09 UTC) #1
Bernhard Bauer
lgtm
6 years, 6 months ago (2014-06-11 08:42:31 UTC) #2
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-11 17:48:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/321393002/20001
6 years, 6 months ago (2014-06-11 17:51:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:14:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:18:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26133)
6 years, 6 months ago (2014-06-11 21:18:46 UTC) #7
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-11 21:20:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/321393002/20001
6 years, 6 months ago (2014-06-11 21:22:18 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:40:50 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:42:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38036) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19681)
6 years, 6 months ago (2014-06-11 21:42:58 UTC) #12
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-11 21:45:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/321393002/20001
6 years, 6 months ago (2014-06-11 21:46:41 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:54:12 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:20:45 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38059)
6 years, 6 months ago (2014-06-11 22:20:47 UTC) #17
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-11 22:48:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/321393002/20001
6 years, 6 months ago (2014-06-11 22:49:41 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:57:39 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:59:46 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26275)
6 years, 6 months ago (2014-06-11 22:59:47 UTC) #22
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-11 23:31:29 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/321393002/20001
6 years, 6 months ago (2014-06-11 23:35:47 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:27:07 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:36:01 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38191)
6 years, 6 months ago (2014-06-12 00:36:03 UTC) #27
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-12 05:32:58 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/321393002/20001
6 years, 6 months ago (2014-06-12 05:38:51 UTC) #29
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 10:33:25 UTC) #30
Message was sent while issue was closed.
Change committed as 276619

Powered by Google App Engine
This is Rietveld 408576698