Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: public/web/WebWidget.h

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixing Sami's suggestions. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/web/WebBeginFrameArgs.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebWidget.h
diff --git a/public/web/WebWidget.h b/public/web/WebWidget.h
index 54b00f3506d41f3f114ebfb022abf5ac6b577916..f8fcd0f25880271ee0a235e7dc7295f0fb8ac4f9 100644
--- a/public/web/WebWidget.h
+++ b/public/web/WebWidget.h
@@ -35,6 +35,7 @@
#include "../platform/WebCommon.h"
#include "../platform/WebRect.h"
#include "../platform/WebSize.h"
+#include "WebBeginFrameArgs.h"
#include "WebCompositionUnderline.h"
#include "WebTextDirection.h"
#include "WebTextInputInfo.h"
@@ -88,7 +89,12 @@ public:
// Called to update imperative animation state. This should be called before
// paint, although the client can rate-limit these calls.
- virtual void animate(double monotonicFrameBeginTime) { }
+ // FIXME(mithro): Remove this function once Chrome side patch lands.
+ void animate(double monotonicFrameBeginTime)
+ {
+ beginFrame(WebBeginFrameArgs(monotonicFrameBeginTime));
+ }
+ virtual void beginFrame(const WebBeginFrameArgs frameTime) { }
Sami 2014/07/16 14:38:55 Should be a const reference instead of just const:
mithro-old 2014/07/17 03:59:17 Done.
// Called to layout the WebWidget. This MUST be called before Paint,
// and it may result in calls to WebWidgetClient::didInvalidateRect.
« no previous file with comments | « public/web/WebBeginFrameArgs.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698