Source/web/WebViewImpl.h - Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Refactoring and reducing this patch based on nduca's suggestions. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index 79bff424c394b5d4e19488b42197f28ec51d067b..dab8ea835e77129eb63d75dfe7c0dc112081fb97 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -41,6 +41,7 @@

#include "public/platform/WebRect.h"

#include "public/platform/WebSize.h"

#include "public/platform/WebString.h"

+#include "public/web/WebBeginFrameArgs.h"

Sami 2014/07/16 10:41:15 I don't think you need this include here since the

mithro-old 2014/07/16 14:26:49 Done.

#include "public/web/WebInputEvent.h"

#include "public/web/WebNavigationPolicy.h"

#include "public/web/WebView.h"

@@ -98,7 +99,9 @@ public:

virtual void didEnterFullScreen() OVERRIDE;

virtual void willExitFullScreen() OVERRIDE;

virtual void didExitFullScreen() OVERRIDE;

- virtual void animate(double) OVERRIDE;

+ virtual void beginFrame(WebBeginFrameArgs) OVERRIDE;

virtual void layout() OVERRIDE;

virtual void paint(WebCanvas*, const WebRect&) OVERRIDE;

#if OS(ANDROID)

« no previous file with comments | « Source/web/WebPopupMenuImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | Source/web/WebViewImpl.cpp » ('J')