Source/core/page/AutoscrollController.cpp - Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/AutoscrollController.cpp

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/AutoscrollController.cpp

diff --git a/Source/core/page/AutoscrollController.cpp b/Source/core/page/AutoscrollController.cpp

index b168e004358d3900383afe94cb11b03e3400d767..a227ec234df029d80a6d984fa92679a1f50389d3 100644

--- a/Source/core/page/AutoscrollController.cpp

+++ b/Source/core/page/AutoscrollController.cpp

@@ -215,7 +215,7 @@ bool AutoscrollController::panScrollInProgress() const

// FIXME: This would get get better animation fidelity if it used the monotonicFrameBeginTime instead

// of WTF::currentTime().

-void AutoscrollController::animate(double)

+void AutoscrollController::animate(blink::WebFrameTime frameTime)

{

if (!m_autoscrollRenderer) {

stopAutoscroll();

@@ -225,7 +225,7 @@ void AutoscrollController::animate(double)

EventHandler& eventHandler = m_autoscrollRenderer->frame()->eventHandler();

switch (m_autoscrollType) {

case AutoscrollForDragAndDrop:

- if (WTF::currentTime() - m_dragAndDropAutoscrollStartTime > autoscrollDelay)

+ if (frameTime.frameTime() - m_dragAndDropAutoscrollStartTime > autoscrollDelay)

m_autoscrollRenderer->autoscroll(m_dragAndDropAutoscrollReferencePosition);

break;

case AutoscrollForSelection:

« no previous file with comments | « Source/core/page/AutoscrollController.h ('k') | Source/platform/exported/WebActiveGestureAnimation.h » ('j') | public/platform/WebFrameTime.h » ('J')