Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 321363002: Change results.Add to results.AddResult in memory metrics. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change results.Add to results.AddResult in memory metrics. BUG=383153 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276572

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Tony's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M tools/perf/metrics/memory.py View 1 4 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-11 03:06:59 UTC) #1
nednguyen
6 years, 6 months ago (2014-06-11 03:06:59 UTC) #2
tonyg
lgtm with nits Also, it would be good to diff the buildbot output results before ...
6 years, 6 months ago (2014-06-11 03:29:58 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-11 22:54:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/321363002/20001
6 years, 6 months ago (2014-06-11 22:56:08 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:15:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:16:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15812)
6 years, 6 months ago (2014-06-12 00:17:01 UTC) #8
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-12 03:34:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/321363002/20001
6 years, 6 months ago (2014-06-12 03:36:43 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 07:53:43 UTC) #11
Message was sent while issue was closed.
Change committed as 276572

Powered by Google App Engine
This is Rietveld 408576698