Add __android_log_assert.

Add __android_log_assert.

Called from android logging macro used in mesa.

BUG=358029
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277862

[rjkroege, 2014-06-11 16:02:45]

https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
File third_party/hwcplus/src/hwcplus_util.c (right):

https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
third_party/hwcplus/src/hwcplus_util.c:9: #include <android/log.h>
this wouldn't compile on CrOS right? The includes would be missing.  How will
this work?

https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
third_party/hwcplus/src/hwcplus_util.c:68: void __android_log_assert(const char*
cond, const char* tag, const char* fmt,
can you line-break per chromium style

[fjhenigman, 2014-06-11 17:43:04]

https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
File third_party/hwcplus/src/hwcplus_util.c (right):

https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
third_party/hwcplus/src/hwcplus_util.c:9: #include <android/log.h>
On 2014/06/11 16:02:45, rjkroege wrote:
> this wouldn't compile on CrOS right? The includes would be missing.  How will
> this work?

This is src/third_party/hwcplus/include/android/log.h which gets installed to
/usr/include/hwcplus/android/log.h by the hwcplus chromeos package.
It works.

https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
third_party/hwcplus/src/hwcplus_util.c:68: void __android_log_assert(const char*
cond, const char* tag, const char* fmt,
On 2014/06/11 16:02:45, rjkroege wrote:
> can you line-break per chromium style

I made the second line start after the open paren of the first line.
Hope that's right.  Couldn't find it in any style guide.

[rjkroege, 2014-06-16 22:19:52]

On 2014/06/11 17:43:04, fjhenigman wrote:
>
https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
> File third_party/hwcplus/src/hwcplus_util.c (right):
> 
>
https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
> third_party/hwcplus/src/hwcplus_util.c:9: #include <android/log.h>
> On 2014/06/11 16:02:45, rjkroege wrote:
> > this wouldn't compile on CrOS right? The includes would be missing.  How
will
> > this work?
> 
> This is src/third_party/hwcplus/include/android/log.h which gets installed to
> /usr/include/hwcplus/android/log.h by the hwcplus chromeos package.
> It works.
> 
>
https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
> third_party/hwcplus/src/hwcplus_util.c:68: void __android_log_assert(const
char*
> cond, const char* tag, const char* fmt,
> On 2014/06/11 16:02:45, rjkroege wrote:
> > can you line-break per chromium style
> 
> I made the second line start after the open paren of the first line.
> Hope that's right.  Couldn't find it in any style guide.

http://www.chromium.org/developers/coding-style?

[fjhenigman, 2014-06-17 14:56:37]

On 2014/06/16 22:19:52, rjkroege wrote:
> On 2014/06/11 17:43:04, fjhenigman wrote:
> >
>
https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
> > File third_party/hwcplus/src/hwcplus_util.c (right):
> > 
> >
>
https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
> > third_party/hwcplus/src/hwcplus_util.c:9: #include <android/log.h>
> > On 2014/06/11 16:02:45, rjkroege wrote:
> > > this wouldn't compile on CrOS right? The includes would be missing.  How
> will
> > > this work?
> > 
> > This is src/third_party/hwcplus/include/android/log.h which gets installed
to
> > /usr/include/hwcplus/android/log.h by the hwcplus chromeos package.
> > It works.
> > 
> >
>
https://codereview.chromium.org/321353002/diff/20001/third_party/hwcplus/src/...
> > third_party/hwcplus/src/hwcplus_util.c:68: void __android_log_assert(const
> char*
> > cond, const char* tag, const char* fmt,
> > On 2014/06/11 16:02:45, rjkroege wrote:
> > > can you line-break per chromium style
> > 
> > I made the second line start after the open paren of the first line.
> > Hope that's right.  Couldn't find it in any style guide.
> 
> http://www.chromium.org/developers/coding-style

per our chat, assuming lgtm

[fjhenigman, 2014-06-17 14:56:43]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2014-06-17 14:57:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fjhenigman@chromium.org/321353002/60001

[commit-bot: I haz the power, 2014-06-17 14:57:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 14:57:45]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[rjkroege, 2014-06-17 16:59:52]

lgtm

[commit-bot: I haz the power, 2014-06-17 21:12:02]

Change committed as 277862