Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/gn/ninja_action_target_writer.cc

Issue 321323004: Add yasm to the GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_rebase_path.cc ('k') | tools/gn/ninja_action_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_action_target_writer.cc
diff --git a/tools/gn/ninja_action_target_writer.cc b/tools/gn/ninja_action_target_writer.cc
index 27bd8a4c58f953508cbcd4ed49ea66d2e2bdc154..7f14e74660e4d7ca1ef2b4a493fde850da3eda43 100644
--- a/tools/gn/ninja_action_target_writer.cc
+++ b/tools/gn/ninja_action_target_writer.cc
@@ -57,10 +57,6 @@ void NinjaActionTargetWriter::Run() {
// Write a rule that invokes the script once with the outputs as outputs,
// and the data as inputs.
out_ << "build";
- if (target_->action_values().has_depfile()) {
- out_ << " ";
- WriteDepfile(SourceFile());
- }
const Target::FileList& outputs = target_->action_values().outputs();
for (size_t i = 0; i < outputs.size(); i++) {
OutputFile output_path(
@@ -211,12 +207,6 @@ void NinjaActionTargetWriter::WriteOutputFilesForBuildLine(
const FileTemplate& output_template,
const SourceFile& source,
std::vector<OutputFile>* output_files) {
- // If there is a depfile specified we need to list it as the first output as
- // that is what ninja will expect the depfile to refer to itself as.
- if (target_->action_values().has_depfile()) {
- out_ << " ";
- WriteDepfile(source);
- }
std::vector<std::string> output_template_result;
output_template.ApplyString(source.value(), &output_template_result);
for (size_t out_i = 0; out_i < output_template_result.size(); out_i++) {
« no previous file with comments | « tools/gn/function_rebase_path.cc ('k') | tools/gn/ninja_action_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698