Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 321323003: Stops using ConvertRectToPixel in snapshot_aura. (Closed)

Created:
6 years, 6 months ago by Jun Mukai
Modified:
6 years, 6 months ago
Reviewers:
danakj, sky, piman
CC:
chromium-reviews
Visibility:
Public.

Description

Stops using ConvertRectToPixel in snapshot_aura. The CopyOutputRequest's area is now in layer's scale factor, not in pixel. R=danakj@chromium.org, piman@chromium.org BUG=381578 TEST=manually, snapshot_unittests succeeds Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276612

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/snapshot/snapshot_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Jun Mukai
6 years, 6 months ago (2014-06-11 18:06:21 UTC) #1
danakj
As on the bug, let's get a test that would fail without this change please, ...
6 years, 6 months ago (2014-06-11 18:12:17 UTC) #2
Jun Mukai
Fixed the test. Confirmed that DeviceScaleFactor and RotateAndUIScaleAndScaleFactor fail on ToT. I think these test ...
6 years, 6 months ago (2014-06-11 18:36:50 UTC) #3
danakj
Thanks, LGTM
6 years, 6 months ago (2014-06-11 18:41:04 UTC) #4
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-11 18:41:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/321323003/20001
6 years, 6 months ago (2014-06-11 18:43:58 UTC) #6
danakj
You'll need a ui/snapshot owner. +sky
6 years, 6 months ago (2014-06-11 18:49:38 UTC) #7
sky
LGTM
6 years, 6 months ago (2014-06-11 19:53:59 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:18:22 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:25:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/37991)
6 years, 6 months ago (2014-06-11 21:25:13 UTC) #11
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-11 21:37:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/321323003/20001
6 years, 6 months ago (2014-06-11 21:39:37 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:54:02 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:23:00 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19714)
6 years, 6 months ago (2014-06-11 22:23:01 UTC) #16
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-12 05:31:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/321323003/20001
6 years, 6 months ago (2014-06-12 05:33:56 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 10:06:54 UTC) #19
Message was sent while issue was closed.
Change committed as 276612

Powered by Google App Engine
This is Rietveld 408576698