Censor dart:_blink and dart:builtin from the enumeration of libraries in the isolate and from impor…

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
@@ skipping 367 matching lines @@
 }
 
 
 static RawInstance* CreateLibraryMirror(const Library& lib) {
   const Array& args = Array::Handle(Array::New(3));
   args.SetAt(0, MirrorReference::Handle(MirrorReference::New(lib)));
   String& str = String::Handle();
   str = lib.name();
   args.SetAt(1, str);
   str = lib.url();
+  if (str.Equals("dart:builtin") || str.Equals("dart:_blink")) {
+    // Censored library (grumble).
+    return Instance::null();
+  }
   args.SetAt(2, str);
   return CreateMirror(Symbols::_LocalLibraryMirror(), args);
 }
 
 
 static RawInstance* CreateCombinatorMirror(const Object& identifiers,
                                            bool is_show) {
   const Array& args = Array::Handle(Array::New(2));
   args.SetAt(0, identifiers);
   args.SetAt(1, Bool::Get(is_show));
   return CreateMirror(Symbols::_LocalCombinatorMirror(), args);
 }
 
 
 static RawInstance* CreateLibraryDependencyMirror(const Instance& importer,
                                                   const Namespace& ns,
                                                   const String& prefix,
                                                   bool is_import) {
   const Library& importee = Library::Handle(ns.library());
   const Instance& importee_mirror =
       Instance::Handle(CreateLibraryMirror(importee));
+  if (importee_mirror.IsNull()) {
+    // Imported library is censored: censor the import.
+    return Instance::null();
+  }
 
   const Array& show_names = Array::Handle(ns.show_names());
   const Array& hide_names = Array::Handle(ns.hide_names());
   intptr_t n = show_names.IsNull() ? 0 : show_names.Length();
   intptr_t m = hide_names.IsNull() ? 0 : hide_names.Length();
   const Array& combinators = Array::Handle(Array::New(n + m));
   Object& t = Object::Handle();
   intptr_t i = 0;
   for (intptr_t j = 0; j < n; j++) {
     t = show_names.At(j);
@@ skipping 35 matching lines @@
   String& prefix = String::Handle();
   GrowableObjectArray& deps =
       GrowableObjectArray::Handle(GrowableObjectArray::New());
 
   // Unprefixed imports.
   ports = lib.imports();
   for (intptr_t i = 0; i < ports.Length(); i++) {
     ns ^= ports.At(i);
     if (!ns.IsNull()) {
       dep = CreateLibraryDependencyMirror(lib_mirror, ns, prefix, true);
-      deps.Add(dep);
+      if (!dep.IsNull()) {
+        deps.Add(dep);
+      }
     }
   }
 
   // Exports.
   ports = lib.exports();
   for (intptr_t i = 0; i < ports.Length(); i++) {
     ns ^= ports.At(i);
     dep = CreateLibraryDependencyMirror(lib_mirror, ns, prefix, false);
-    deps.Add(dep);
+    if (!dep.IsNull()) {
+      deps.Add(dep);
+    }
   }
 
   // Prefixed imports.
   DictionaryIterator entries(lib);
   Object& entry = Object::Handle();
   while (entries.HasNext()) {
     entry = entries.GetNext();
     if (entry.IsLibraryPrefix()) {
       const LibraryPrefix& lib_prefix = LibraryPrefix::Cast(entry);
       prefix = lib_prefix.name();
       ports = lib_prefix.imports();
       for (intptr_t i = 0; i < ports.Length(); i++) {
         ns ^= ports.At(i);
         if (!ns.IsNull()) {
           dep = CreateLibraryDependencyMirror(lib_mirror, ns, prefix, true);
-          deps.Add(dep);
+          if (!dep.IsNull()) {
+            deps.Add(dep);
+          }
         }
       }
     }
   }
 
   return deps.raw();
 }
 
 static RawInstance* CreateTypeMirror(const AbstractType& type) {
   if (type.IsTypeRef()) {
@@ skipping 42 matching lines @@
 
   const Array& args = Array::Handle(Array::New(2));
   args.SetAt(0, debug_name);
   args.SetAt(1, root_library_mirror);
   return CreateMirror(Symbols::_LocalIsolateMirror(), args);
 }
 
 
 static RawInstance* CreateMirrorSystem() {
   Isolate* isolate = Isolate::Current();
-  const GrowableObjectArray& libraries =
-      GrowableObjectArray::Handle(isolate->object_store()->libraries());
+  const GrowableObjectArray& libraries = GrowableObjectArray::Handle(
+      isolate, isolate->object_store()->libraries());
 
   const intptr_t num_libraries = libraries.Length();
-  const Array& library_mirrors = Array::Handle(Array::New(num_libraries));
-  Library& library = Library::Handle();
-  Instance& library_mirror = Instance::Handle();
+  const GrowableObjectArray& library_mirrors = GrowableObjectArray::Handle(
+      isolate, GrowableObjectArray::New(num_libraries));
+  Library& library = Library::Handle(isolate);
+  Instance& library_mirror = Instance::Handle(isolate);
 
   for (int i = 0; i < num_libraries; i++) {
     library ^= libraries.At(i);
     library_mirror = CreateLibraryMirror(library);
-    library_mirrors.SetAt(i, library_mirror);
+    if (!library_mirror.IsNull()) {
+      library_mirrors.Add(library_mirror);
+    }
   }
 
   const Instance& isolate_mirror = Instance::Handle(CreateIsolateMirror());
 
   const Array& args = Array::Handle(Array::New(2));
   args.SetAt(0, library_mirrors);
   args.SetAt(1, isolate_mirror);
   return CreateMirror(Symbols::_LocalMirrorSystem(), args);
 }
 
@@ skipping 1375 matching lines @@
 }
 
 DEFINE_NATIVE_ENTRY(TypeMirror_moreSpecificTest, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, a, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, b, arguments->NativeArgAt(1));
   return Bool::Get(a.IsMoreSpecificThan(b, NULL)).raw();
 }
 
 
 }  // namespace dart