Clear SDCH information on "Clear browsing data" path.

net/base/sdch_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 423 matching lines @@
   GURL secure_url("https://www.google.com");
 
   EXPECT_TRUE(sdch_manager()->IsInSupportedDomain(url));
   EXPECT_FALSE(sdch_manager()->IsInSupportedDomain(secure_url));
 
   SdchManager::EnableSecureSchemeSupport(true);
   EXPECT_TRUE(sdch_manager()->IsInSupportedDomain(url));
   EXPECT_TRUE(sdch_manager()->IsInSupportedDomain(secure_url));
 }
 
+TEST_F(SdchManagerTest, ClearDictionaryData) {
+  std::string dictionary_domain("x.y.z.google.com");
+  GURL blacklist_url("http://bad.chromium.org");
+
+  std::string dictionary_text(NewSdchDictionary(dictionary_domain));
+  std::string tmp_hash;
+  std::string server_hash;
+
+  SdchManager::GenerateHash(dictionary_text, &tmp_hash, &server_hash);
+
+  EXPECT_TRUE(sdch_manager()->AddSdchDictionary(
+      dictionary_text, GURL("http://" + dictionary_domain)));
+  SdchManager::Dictionary* dictionary = NULL;
+  sdch_manager()->GetVcdiffDictionary(
+      server_hash,
+      GURL("http://" + dictionary_domain + "/random_url"),
+      &dictionary);
+  EXPECT_TRUE(dictionary);
+
+  sdch_manager()->BlacklistDomain(GURL(blacklist_url));
+  EXPECT_FALSE(sdch_manager()->IsInSupportedDomain(blacklist_url));
+
+  sdch_manager()->ClearData();

[jar (doing other things), 2014/06/17 05:48:55]

This is probably the line of code that was critical to inducing (exposing) the
leak in the reported revert stack.

The dictionary created during the call in line 457 gets leaked.

[Randy Smith (Not in Mondays), 2014/06/17 18:33:11]

Done.

+
+  dictionary = NULL;
+  sdch_manager()->GetVcdiffDictionary(
+      server_hash,
+      GURL("http://" + dictionary_domain + "/random_url"),
+      &dictionary);
+  EXPECT_FALSE(dictionary);
+  EXPECT_TRUE(sdch_manager()->IsInSupportedDomain(blacklist_url));
+}
+
 }  // namespace net