Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5339)

Unified Diff: chrome/browser/omnibox/omnibox_field_trial.h

Issue 321243003: Omnibox: Add Field Trial to Create UWYT When Inlining (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.cc ('k') | chrome/browser/omnibox/omnibox_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/omnibox/omnibox_field_trial.h
diff --git a/chrome/browser/omnibox/omnibox_field_trial.h b/chrome/browser/omnibox/omnibox_field_trial.h
index f6599eaf732a272e9277b2d589dca0932f0f3c5f..846ee31e0118dba67c3f58642ebc005c93c5f9f4 100644
--- a/chrome/browser/omnibox/omnibox_field_trial.h
+++ b/chrome/browser/omnibox/omnibox_field_trial.h
@@ -292,6 +292,23 @@ class OmniboxFieldTrial {
static bool EnableAnswersInSuggest();
// ---------------------------------------------------------
+ // For the AddUWYTMatchEvenIfPromotedURLs experiment that's part of the
+ // bundled omnibox field trial.
+
+ // Returns true if HistoryURL Provider should add the URL-what-you-typed match
+ // (if valid and reasonable) even if the provider has good inline
+ // autocompletions to offer. Normally HistoryURL does not add the UWYT match
+ // if there are good inline autocompletions, as the user could simply hit
+ // backspace to delete the completion and get the what-you-typed match.
+ // However, in the disable inlining experiment this interaction is a lot more
+ // difficult. The user will have to select a not-inlined suggestion and
+ // backspace (possibly a lot) to get back to the what-you-typed match.
+ // This mode is intended to alleviate the pain by always ensuring that
+ // the UWYT match appears somewhere on the list of suggestions. Returns
+ // false if the experiment isn't active.
+ static bool AddUWYTMatchEvenIfPromotedURLs();
+
+ // ---------------------------------------------------------
// Exposed publicly for the sake of unittests.
static const char kBundledExperimentFieldTrialName[];
// Rule names used by the bundled experiment.
@@ -307,6 +324,7 @@ class OmniboxFieldTrial {
static const char kBookmarksIndexURLsRule[];
static const char kDisableInliningRule[];
static const char kAnswersInSuggestRule[];
+ static const char kAddUWYTMatchEvenIfPromotedURLsRule[];
// Parameter names used by the HUP new scoring experiments.
static const char kHUPNewScoringEnabledParam[];
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.cc ('k') | chrome/browser/omnibox/omnibox_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698