Issue 321233004: MSE: Remap single text track number changes in frame processor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321233004: MSE: Remap single text track number changes in frame processor (Closed)

Created:
6 years, 6 months ago by wolenetz

Modified:
6 years, 6 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

MSE: Remap single text track number changes in frame processor If a sequence of init segments changes the track number of a text track, and there is just one text track (in addition to possible audio/video tracks) in each init segment, then update the frame processor's track buffer map to allow appends to the text track to be mapped to the same underlying track buffer. Note that we would need to do similar for audio and video if we ever support more than one of each of those type tracks per SourceBuffer. BUG=383076 R=acolwell@chromium.org TEST=shiny new test (SingleTextTrackIdChange) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276307

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -10 lines)			Patch
M	media/filters/chunk_demuxer.cc	View	1 2	1 chunk	+11 lines, -2 lines	0 comments	Download
M	media/filters/chunk_demuxer_unittest.cc	View		6 chunks	+84 lines, -8 lines	0 comments	Download
M	media/filters/frame_processor_base.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	media/filters/frame_processor_base.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/321233004/40001

6 years, 6 months ago (2014-06-10 23:33:05 UTC) #5

Message was sent while issue was closed.

Change committed as 276307

Expand Messages | Collapse Messages

Issue 321233004: MSE: Remap single text track number changes in frame processor (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix lint nit #

Patch Set 3 : Fixes a couple nits #

Messages