Print Preview: Enable tests disabled on ASAN once again.

chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/task_manager/task_manager_browsertest_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
+#include "url/url_constants.h"
 
 #if defined(OS_WIN)
 #include "ui/aura/window.h"
 #include "ui/aura/window_tree_host.h"
 #endif
 
 using task_manager::browsertest_util::MatchAboutBlankTab;
 using task_manager::browsertest_util::MatchAnyPrint;
 using task_manager::browsertest_util::MatchAnyTab;
 using task_manager::browsertest_util::MatchPrint;
 using task_manager::browsertest_util::WaitForTaskManagerRows;
 
 namespace {
 
 class PrintPreviewTest : public InProcessBrowserTest {
  public:
   PrintPreviewTest() {}
 
   void Print() {
     content::TestNavigationObserver nav_observer(NULL);
     nav_observer.StartWatchingNewWebContents();
     chrome::ExecuteCommand(browser(), IDC_PRINT);
     nav_observer.Wait();
     nav_observer.StopWatchingNewWebContents();
   }
 };
 
-// The two tests below are failing on Linux LSAN
-// crbug.com/382523
-#if !defined(ADDRESS_SANITIZER)
-
 IN_PROC_BROWSER_TEST_F(PrintPreviewTest, PrintCommands) {
   // We start off at about:blank page.
   // Make sure there is 1 tab and print is enabled.
   ASSERT_EQ(1, browser()->tab_strip_model()->count());
 
   ASSERT_TRUE(chrome::IsCommandEnabled(browser(), IDC_PRINT));
 
   // Make sure advanced print command (Ctrl+Shift+p) is enabled.
   ASSERT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ADVANCED_PRINT));
 
@@ skipping 29 matching lines @@
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, MatchAnyPrint()));
 
   // Create the print preview dialog.
   Print();
 
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyPrint()));
-  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchPrint("about:blank")));
+  ASSERT_NO_FATAL_FAILURE(
+      WaitForTaskManagerRows(1, MatchPrint(url::kAboutBlankURL)));
 }
 
-#endif
-
 // Disable the test for mac as it started being flaky, see http://crbug/367665.
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 #define MAYBE_TaskManagerExistingPrintPreview DISABLED_TaskManagerExistingPrintPreview
-// Disable the test for Linux LSAN, see http://crbug.com/382764.
-#elif defined(OS_LINUX) && defined(ADDRESS_SANITIZER)
-#define MAYBE_TaskManagerExistingPrintPreview DISABLED_TaskManagerExistingPrintPreview
 #else
 #define MAYBE_TaskManagerExistingPrintPreview TaskManagerExistingPrintPreview
 #endif
 IN_PROC_BROWSER_TEST_F(PrintPreviewTest,
                        MAYBE_TaskManagerExistingPrintPreview) {
   // Create the print preview dialog.
   Print();
 
   chrome::ShowTaskManager(browser());  // Show task manager AFTER print dialog.
 
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyPrint()));
-  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchPrint("about:blank")));
+  ASSERT_NO_FATAL_FAILURE(
+      WaitForTaskManagerRows(1, MatchPrint(url::kAboutBlankURL)));
 }
 
 #if defined(OS_WIN)
-
 BOOL CALLBACK EnumerateChildren(HWND hwnd, LPARAM l_param) {
   HWND* child = reinterpret_cast<HWND*>(l_param);
   *child = hwnd;
   // The first child window is the plugin, then its children. So stop
   // enumerating after the first callback.
   return FALSE;
 }
 
 // This test verifies that constrained windows aren't covered by windowed NPAPI
 // plugins. The code which fixes this is in WebContentsViewAura::WindowObserver.
@@ skipping 55 matching lines @@
       browser(), GURL("about:blank"), NEW_FOREGROUND_TAB,
       ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
 
   browser()->tab_strip_model()->ActivateTabAt(0, true);
 
   // Navigate main tab to hide print preview.
   ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
 
   browser()->tab_strip_model()->ActivateTabAt(1, true);
 }
-#endif
+#endif  // defined(OS_WIN)
 
 }  // namespace