Issue 321223002: Update the window shape when toggling whether the system titlebar and borders are used on KDE

Issue 321223002: Update the window shape when toggling whether the system titlebar and borders are used on KDE (Closed)

Created:
6 years, 6 months ago by pkotwicz

Modified:
6 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, tdanderson+views_chromium.org, tfarina, jar+watch_chromium.org, asvitkine+watch_chromium.org, ben+views_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update the window shape when toggling whether the system titlebar and borders are used on KDE BUG=383111 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276308

Patch Set 1 : #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc	View		2 chunks	+2 lines, -3 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

Elliot, PTAL https://codereview.chromium.org/321223002/diff/40001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/321223002/diff/40001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1275 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1275: ResetWindowRegion(); I am unsure if XShapeCombineRectangles() is ...

6 years, 6 months ago (2014-06-10 22:00:53 UTC) #1

Elliot Glaysher

lgtm I don't know either. sadrul might know, if he's around. piman is still out, ...

6 years, 6 months ago (2014-06-10 22:06:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/321223002/40001

6 years, 6 months ago (2014-06-10 22:26:00 UTC) #4

Message was sent while issue was closed.

Change committed as 276308

Expand Messages | Collapse Messages