Issue 3212009: Move BitmapPlatformDeviceData into its own header file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3212009: Move BitmapPlatformDeviceData into its own header file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by tony

Modified:
4 years ago

Reviewers:
brettw

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Move BitmapPlatformDeviceData into its own header file. I'm trying to share some common code between the platforms so I'm starting by merging into a common header file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58034

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : add to gyp #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -175 lines)			Patch
A	skia/ext/bitmap_platform_device_data.h	View	1 2	1 chunk	+106 lines, -0 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_linux.cc	View		4 chunks	+11 lines, -62 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_mac.cc	View		7 chunks	+12 lines, -58 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_win.cc	View		4 chunks	+6 lines, -55 lines	0 comments	Download
M	skia/skia.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Trybot results: win linux mac linux_view

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages