Issue 321183002: Use context manager to manage OS environment in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321183002: Use context manager to manage OS environment in tests (Closed)

Created:
6 years, 6 months ago by yukawa

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com, Nico

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

Use context manager to manage OS environment in tests This is a follow up CL for gyp r1931, just for the code cleanup. Inspired by Nico's gyp r1893. BUG=gyp:434 TEST=unittest R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1934

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -10 lines)			Patch
	M	test/make_global_settings/ar/gyptest-make_global_settings_ar.py	View		2 chunks	+3 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

yukawa

6 years, 6 months ago (2014-06-12 13:25:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1934 (presubmit successful).