Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 321163003: binary_size: Fix jobs number parsing (Closed)

Created:
6 years, 6 months ago by emoller
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Daniel Bratell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

binary_size: Fix jobs number parsing BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/binary_size/run_binary_size_analysis.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
emoller
The jobs parameter in the updated binary size tool was read in as a string ...
6 years, 6 months ago (2014-06-10 09:39:17 UTC) #1
Andrew Hayden (chromium.org)
Whoops. LGTM, thanks for fixing.
6 years, 6 months ago (2014-06-10 09:40:57 UTC) #2
emoller
The CQ bit was checked by emoller@opera.com
6 years, 6 months ago (2014-06-10 09:44:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/emoller@opera.com/321163003/1
6 years, 6 months ago (2014-06-10 09:47:28 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 17:04:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 17:45:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150463)
6 years, 6 months ago (2014-06-10 17:45:22 UTC) #7
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 6 months ago (2014-06-10 20:30:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/emoller@opera.com/321163003/1
6 years, 6 months ago (2014-06-10 20:31:52 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 21:37:21 UTC) #10
Message was sent while issue was closed.
Change committed as 276164

Powered by Google App Engine
This is Rietveld 408576698