Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: include/v8-util.h

Issue 321123002: Make presubmit script happy again. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | samples/process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-util.h
diff --git a/include/v8-util.h b/include/v8-util.h
index 86549252b836bbad8c89d8aa667245c683b4bbff..1eaf1ab68f6be618a6690c25b7e10a297e88ee6e 100644
--- a/include/v8-util.h
+++ b/include/v8-util.h
@@ -154,7 +154,7 @@ class PersistentValueMap {
*/
bool SetReturnValue(const K& key,
ReturnValue<Value> returnValue) {
- return SetReturnValueFromVal(returnValue, Traits::Get(&impl_, key));
+ return SetReturnValueFromVal(&returnValue, Traits::Get(&impl_, key));
}
/**
@@ -227,7 +227,7 @@ class PersistentValueMap {
}
template<typename T>
bool SetReturnValue(ReturnValue<T> returnValue) {
- return SetReturnValueFromVal(returnValue, value_);
+ return SetReturnValueFromVal(&returnValue, value_);
}
void Reset() {
value_ = kPersistentContainerNotFound;
@@ -309,10 +309,10 @@ class PersistentValueMap {
}
static bool SetReturnValueFromVal(
- ReturnValue<Value>& returnValue, PersistentContainerValue value) {
+ ReturnValue<Value>* returnValue, PersistentContainerValue value) {
bool hasValue = value != kPersistentContainerNotFound;
if (hasValue) {
- returnValue.SetInternal(
+ returnValue->SetInternal(
*reinterpret_cast<internal::Object**>(FromVal(value)));
}
return hasValue;
« no previous file with comments | « no previous file | samples/process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698