Source/devtools/front_end/sources/SourcesPanel.js - Issue 321113005: DevTools: Support XHR event listener breakpoints on frontend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 321113005: DevTools: Support XHR event listener breakpoints on frontend. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/sources/SourcesPanel.js

diff --git a/Source/devtools/front_end/sources/SourcesPanel.js b/Source/devtools/front_end/sources/SourcesPanel.js

index 1a0d81cd002faff2283cfe500025d2211c56fd43..cb5ac142ced9b298bbdfef4acd1a95d12ae5d995 100644

--- a/Source/devtools/front_end/sources/SourcesPanel.js

+++ b/Source/devtools/front_end/sources/SourcesPanel.js

@@ -277,15 +277,16 @@ WebInspector.SourcesPanel.prototype = {

WebInspector.domBreakpointsSidebarPane.highlightBreakpoint(details.auxData);

WebInspector.domBreakpointsSidebarPane.createBreakpointHitStatusMessage(details, didCreateBreakpointHitStatusMessage.bind(this));

} else if (details.reason === WebInspector.DebuggerModel.BreakReason.EventListener) {

- var eventName = details.auxData.eventName;

- this.sidebarPanes.eventListenerBreakpoints.highlightBreakpoint(details.auxData.eventName);

+ var eventName = details.auxData["eventName"];

+ var targetName = details.auxData["targetName"];

+ this.sidebarPanes.eventListenerBreakpoints.highlightBreakpoint(eventName, targetName);

var eventNameForUI = WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI(eventName, details.auxData);

this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a \"%s\" Event Listener.", eventNameForUI));

} else if (details.reason === WebInspector.DebuggerModel.BreakReason.XHR) {

this.sidebarPanes.xhrBreakpoints.highlightBreakpoint(details.auxData["breakpointURL"]);

this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a XMLHttpRequest."));

} else if (details.reason === WebInspector.DebuggerModel.BreakReason.Exception)

- this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on exception: '%s'.", details.auxData.description));

+ this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on exception: '%s'.", details.auxData["description"]));

else if (details.reason === WebInspector.DebuggerModel.BreakReason.Assert)

this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on assertion."));

else if (details.reason === WebInspector.DebuggerModel.BreakReason.CSPViolation)