DevTools: Support XHR event listener breakpoints on frontend.

DevTools: Support XHR event listener breakpoints on frontend.

BUG=381470
R=yurys@chromium.org, pfeldman@chromium.org, vsevik, yurys

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176318

[yurys, 2014-06-11 12:31:23]

https://codereview.chromium.org/321113005/diff/1/Source/devtools/front_end/so...
File Source/devtools/front_end/sources/BreakpointsSidebarPane.js (right):

https://codereview.chromium.org/321113005/diff/1/Source/devtools/front_end/so...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:537:
this._createCategory(WebInspector.UIString("Timer"), ["setTimer", "clearTimer",
"timerFired"], null);
It was more clear with boolean isDOMEvent, may be we should pass category
explicitly? null vs undefined is too obscure to my taste.

https://codereview.chromium.org/321113005/diff/1/Source/devtools/front_end/so...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:602: var eventName =
(targetNames === null ?
WebInspector.EventListenerBreakpointsSidebarPane.categoryInstrumentation : 
WebInspector.EventListenerBreakpointsSidebarPane.categoryListener) +
eventNames[i];
Category evaluation can be moved out of the loop body.

[aandrey, 2014-06-11 12:49:18]

PTAL

https://codereview.chromium.org/321113005/diff/1/Source/devtools/front_end/so...
File Source/devtools/front_end/sources/BreakpointsSidebarPane.js (right):

https://codereview.chromium.org/321113005/diff/1/Source/devtools/front_end/so...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:537:
this._createCategory(WebInspector.UIString("Timer"), ["setTimer", "clearTimer",
"timerFired"], null);
On 2014/06/11 12:31:23, yurys wrote:
> It was more clear with boolean isDOMEvent, may be we should pass category
> explicitly? null vs undefined is too obscure to my taste.

Done.

https://codereview.chromium.org/321113005/diff/1/Source/devtools/front_end/so...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:602: var eventName =
(targetNames === null ?
WebInspector.EventListenerBreakpointsSidebarPane.categoryInstrumentation : 
WebInspector.EventListenerBreakpointsSidebarPane.categoryListener) +
eventNames[i];
On 2014/06/11 12:31:23, yurys wrote:
> Category evaluation can be moved out of the loop body.

Done.

[aandrey, 2014-06-16 09:10:07]

ping?

[yurys, 2014-06-16 12:07:24]

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/sources/BreakpointsSidebarPane.js (right):

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:732: delete
categoryItem.dirtyCheckbox;
 categoryItem.dirtyCheckbox = false;

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:733: var hasEnabled
= false, hasDisabled = false;
one assignment per line please

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:760: return
breakpointItem;
Consider doing "return breakpointItem || null;" unconditionally?

[yurys, 2014-06-16 12:22:10]

lgtm

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/sources/BreakpointsSidebarPane.js (right):

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:539:
this._createCategory(WebInspector.UIString("XHR"), ["readystatechange", "load",
"loadstart", "loadend", "abort", "error", "progress", "timeout"], false,
["XMLHttpRequest", "XMLHttpRequestUpload"]);
It is a bit confusing that we mix categories and targets on the same level. We
may want a better separation in UI, e.g. first all events are grouped by
targets, under each target events grouped by categories. Can be addressed in a
separate change.

[aandrey, 2014-06-16 12:23:39]

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/sources/BreakpointsSidebarPane.js (right):

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:732: delete
categoryItem.dirtyCheckbox;
On 2014/06/16 12:07:24, yurys wrote:
>  categoryItem.dirtyCheckbox = false;

Done.

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:733: var hasEnabled
= false, hasDisabled = false;
On 2014/06/16 12:07:24, yurys wrote:
> one assignment per line please

Done.

https://codereview.chromium.org/321113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/sources/BreakpointsSidebarPane.js:760: return
breakpointItem;
On 2014/06/16 12:07:24, yurys wrote:
> Consider doing "return breakpointItem || null;" unconditionally?

depending on the condition, we may have to proceed the loop interation

[aandrey, 2014-06-16 12:24:43]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-16 12:25:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/321113005/40001

[commit-bot: I haz the power, 2014-06-16 14:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 14:18:02]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12104)

[aandrey, 2014-06-16 14:22:06]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-16 14:23:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/321113005/40001

[commit-bot: I haz the power, 2014-06-16 16:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 16:34:39]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12124)

[aandrey, 2014-06-16 18:26:30]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-16 18:27:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/321113005/40001

[commit-bot: I haz the power, 2014-06-16 20:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 20:20:54]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12154)

[aandrey, 2014-06-17 10:12:05]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-17 10:12:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/321113005/40001

[commit-bot: I haz the power, 2014-06-17 11:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 11:58:28]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12294)

[aandrey, 2014-06-17 12:41:02]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-17 12:42:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/321113005/80001

[commit-bot: I haz the power, 2014-06-17 14:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 14:50:01]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[aandrey, 2014-06-17 14:53:31]

Committed patchset #4 manually as r176318 (presubmit successful).