Issue 3211001: Bring r5350 and r5353 to the 2.2 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3211001: Bring r5350 and r5353 to the 2.2 branch. (Closed)

Created:
10 years, 4 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/2.2/

Visibility:
Public.

Description

Bring r5350 and r5353 to the 2.2 branch. Committed: http://code.google.com/p/v8/source/detail?r=5355

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -9 lines)			Patch
M	src/v8natives.js	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/cctest.status	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-842.js	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/3211001/diff/1/2 File src/v8natives.js (right): http://codereview.chromium.org/3211001/diff/1/2#newcode792 src/v8natives.js:792: if (desc.isConfigurable()) return false; Indentation, fix here and ...

10 years, 4 months ago (2010-08-26 12:59:10 UTC) #3

Rico

10 years, 4 months ago (2010-08-26 13:04:01 UTC) #4

http://codereview.chromium.org/3211001/diff/1/2
File src/v8natives.js (right):

http://codereview.chromium.org/3211001/diff/1/2#newcode792
src/v8natives.js:792: if (desc.isConfigurable()) return false;
On 2010/08/26 12:59:11, Mads Ager wrote:
> Indentation, fix here and in bleeding_edge?

Done.

Expand Messages | Collapse Messages

Issue 3211001: Bring r5350 and r5353 to the 2.2 branch. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages