Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 321093002: Fix ExtensionPopup close issue. (Closed)

Created:
6 years, 6 months ago by Xuefei Ren
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix chrome.extension.getViews returns multiple popup windows. When we invoke +[ExtensionPopupController showURL:...], we close the old Popup using [gPopup close],but we don't release it here. So host_ is only released when -[ExtensionPopupController windowWillClose] is invoked. At this time, the new popup might be ready. And when we use chrome.extension.getViews or some other apis we might get the dying window. So move shutdown of host_ from -[ExtensionPopupController windowWillClose] into -[ExtensionPopupController close]. BUG=376511 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276355

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 3 chunks +14 lines, -6 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Xuefei Ren
6 years, 6 months ago (2014-06-10 05:00:56 UTC) #1
Xuefei Ren
Add some comments about why I do this. https://codereview.chromium.org/321093002/diff/1/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm File chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm (right): https://codereview.chromium.org/321093002/diff/1/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm#newcode291 chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm:291: [gPopup ...
6 years, 6 months ago (2014-06-10 05:24:32 UTC) #2
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-10 21:15:15 UTC) #3
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 6 months ago (2014-06-11 00:57:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/321093002/1
6 years, 6 months ago (2014-06-11 01:02:05 UTC) #5
commit-bot: I haz the power
Change committed as 276355
6 years, 6 months ago (2014-06-11 11:49:50 UTC) #6
Xuefei Ren
6 years, 5 months ago (2014-07-02 06:07:10 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/364783003/ by xrenishere@gmail.com.

The reason for reverting is: Have to revert this. There is some cases such as
when in extension open a new tab with window.open or  a link, this will crash
the browser.See bug 390128..

Powered by Google App Engine
This is Rietveld 408576698