Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 321053005: DevTools: Fix snapshot canvas log test. (Closed)

Created:
6 years, 6 months ago by malch
Modified:
6 years, 6 months ago
Reviewers:
caseq
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/layers/layer-canvas-log.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/layers/layer-canvas-log-expected.txt View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
malch
Please take a look
6 years, 6 months ago (2014-06-10 13:04:14 UTC) #1
caseq
lgtm
6 years, 6 months ago (2014-06-10 13:22:33 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-10 13:23:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/malch@chromium.org/321053005/20001
6 years, 6 months ago (2014-06-10 13:24:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-10 14:39:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 14:39:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/15725)
6 years, 6 months ago (2014-06-10 14:39:52 UTC) #7
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-10 14:42:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/malch@chromium.org/321053005/20001
6 years, 6 months ago (2014-06-10 14:43:38 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-10 14:44:00 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 14:44:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/15725)
6 years, 6 months ago (2014-06-10 14:44:13 UTC) #12
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-10 14:49:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/malch@chromium.org/321053005/20001
6 years, 6 months ago (2014-06-10 14:50:32 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-10 14:51:00 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 14:51:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/15725)
6 years, 6 months ago (2014-06-10 14:51:12 UTC) #17
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-11 07:15:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/malch@chromium.org/321053005/20001
6 years, 6 months ago (2014-06-11 07:16:33 UTC) #19
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 07:17:26 UTC) #20
Message was sent while issue was closed. 
Change committed as 175948

Powered by Google App Engine
This is Rietveld 408576698