Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: ppapi/native_client/src/trusted/plugin/plugin.h

Issue 321053004: Add limitation that LoadNexeAndStart must be called on the main thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/plugin.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // -*- c++ -*- 1 // -*- c++ -*-
2 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
4 // found in the LICENSE file. 4 // found in the LICENSE file.
5 5
6 // The portable representation of an instance and root scriptable object. 6 // The portable representation of an instance and root scriptable object.
7 // The PPAPI version of the plugin instantiates a subclass of this class. 7 // The PPAPI version of the plugin instantiates a subclass of this class.
8 8
9 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_H_ 9 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_H_
10 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_H_ 10 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_H_
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 void SignalStartSelLdrDone(int32_t pp_error, 159 void SignalStartSelLdrDone(int32_t pp_error,
160 bool* started, 160 bool* started,
161 ServiceRuntime* service_runtime); 161 ServiceRuntime* service_runtime);
162 162
163 // Signals that the nexe is started. 163 // Signals that the nexe is started.
164 // This is invoked on the main thread. 164 // This is invoked on the main thread.
165 void SignalNexeStarted(int32_t pp_error, 165 void SignalNexeStarted(int32_t pp_error,
166 bool* started, 166 bool* started,
167 ServiceRuntime* service_runtime); 167 ServiceRuntime* service_runtime);
168 168
169 void LoadNexeAndStart(int32_t pp_error, 169 void LoadNexeAndStart(int32_t pp_error,
teravest 2014/06/10 15:19:25 Please add a comment like the following: " // Th
hidehiko 2014/06/11 07:24:37 Done.
170 ServiceRuntime* service_runtime,
170 PP_NaClFileInfo file_info, 171 PP_NaClFileInfo file_info,
171 ServiceRuntime* service_runtime, 172 const pp::CompletionCallback& callback);
172 const pp::CompletionCallback& crash_cb);
173 173
174 // Callback used when getting the URL for the .nexe file. If the URL loading 174 // Callback used when getting the URL for the .nexe file. If the URL loading
175 // is successful, the file descriptor is opened and can be passed to sel_ldr 175 // is successful, the file descriptor is opened and can be passed to sel_ldr
176 // with the sandbox on. 176 // with the sandbox on.
177 void NexeFileDidOpen(int32_t pp_error); 177 void NexeFileDidOpen(int32_t pp_error);
178 void NexeFileDidOpenContinuation(int32_t pp_error); 178 void NexeFileDidOpenContinuation(int32_t pp_error);
179 179
180 // Callback used when the reverse channel closes. This is an 180 // Callback used when the reverse channel closes. This is an
181 // asynchronous event that might turn into a JavaScript error or 181 // asynchronous event that might turn into a JavaScript error or
182 // crash event -- this is controlled by the two state variables 182 // crash event -- this is controlled by the two state variables
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 227
228 PP_NaClFileInfo nexe_file_info_; 228 PP_NaClFileInfo nexe_file_info_;
229 229
230 const PPB_NaCl_Private* nacl_interface_; 230 const PPB_NaCl_Private* nacl_interface_;
231 pp::UMAPrivate uma_interface_; 231 pp::UMAPrivate uma_interface_;
232 }; 232 };
233 233
234 } // namespace plugin 234 } // namespace plugin
235 235
236 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_H_ 236 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_H_
OLDNEW
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698