Source/core/svg/SVGScriptElement.cpp - Issue 321023002: Avoid branching in createAttributeEventListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGScriptElement.cpp

Issue 321023002: Avoid branching in createAttributeEventListener (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove leftover line Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGScriptElement.cpp

diff --git a/Source/core/svg/SVGScriptElement.cpp b/Source/core/svg/SVGScriptElement.cpp

index 6216ce9d136cf306fd4cab8d49fe4909ba55e03e..b71c8826222e16547efda127661e636004e52a9e 100644

--- a/Source/core/svg/SVGScriptElement.cpp

+++ b/Source/core/svg/SVGScriptElement.cpp

@@ -68,7 +68,7 @@ void SVGScriptElement::parseAttribute(const QualifiedName& name, const AtomicStr

return;

if (name == HTMLNames::onerrorAttr) {

- setAttributeEventListener(EventTypeNames::error, createAttributeEventListener(this, name, value));

+ setAttributeEventListener(EventTypeNames::error, createAttributeEventListener(this, name, value, eventParameterName()));

} else if (SVGURIReference::parseAttribute(name, value, parseError)) {

} else {

ASSERT_NOT_REACHED();