Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4575)

Unified Diff: chrome/renderer/extensions/event_bindings.cc

Issue 3210007: Add support for a "split" incognito behavior for extensions. (Closed)
Patch Set: latest Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/extensions/extension_process_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/event_bindings.cc
diff --git a/chrome/renderer/extensions/event_bindings.cc b/chrome/renderer/extensions/event_bindings.cc
index 52f5d0e1c6e0f22516fda0d7a911c5359bb8eb62..55d1813f2c835e638a39abbf12c0e0f2f7bf61b2 100644
--- a/chrome/renderer/extensions/event_bindings.cc
+++ b/chrome/renderer/extensions/event_bindings.cc
@@ -143,9 +143,9 @@ static bool HasSufficientPermissions(ContextInfo* context,
const GURL& event_url) {
v8::Context::Scope context_scope(context->context);
- bool incognito_permissions_ok = (!requires_incognito_access ||
- ExtensionProcessBindings::HasIncognitoEnabled(context->extension_id));
- if (!incognito_permissions_ok)
+ bool cross_profile_ok = (!requires_incognito_access ||
+ ExtensionProcessBindings::AllowCrossProfile(context->extension_id));
+ if (!cross_profile_ok)
return false;
// During unit tests, we might be invoked without a v8 context. In these
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/extensions/extension_process_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698