Add support for a "split" incognito behavior for extensions.

chrome/common/extensions/extension.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include <algorithm>
 
 #include "app/l10n_util.h"
 #include "base/base64.h"
@@ skipping 732 matching lines @@
   return true;
 }
 
 Extension::Extension(const FilePath& path)
     : converted_from_user_script_(false),
       is_theme_(false),
       is_app_(false),
       launch_container_(LAUNCH_TAB),
       launch_width_(0),
       launch_height_(0),
+      incognito_split_mode_(true),
       background_page_ready_(false),
       being_upgraded_(false) {
   DCHECK(path.IsAbsolute());
 
   apps_enabled_ = AppsAreEnabled();
   location_ = INVALID;
 
 #if defined(OS_WIN)
   // Normalize any drive letter to upper-case. We do this for consistency with
   // net_utils::FilePathToFileURL(), which does the same thing, to make string
@@ skipping 758 matching lines @@
       *error = errors::kInvalidDevToolsPage;
       return false;
     }
     if (!HasApiPermission(Extension::kExperimentalPermission)) {
       *error = errors::kDevToolsExperimental;
       return false;
     }
     devtools_url_ = GetResourceURL(devtools_str);
   }
 
+  }
+
+  // Initialize incognito behavior. Apps default to split mode, extensions
+  // default to spanning.
+  incognito_split_mode_ = is_app_;
+  if (source.HasKey(keys::kIncognito)) {
+    std::string value;
+    if (!source.GetString(keys::kIncognito, &value)) {
+      *error = errors::kInvalidIncognitoBehavior;
+      return false;
+    }
+    if (value == values::kIncognitoSpanning) {
+      incognito_split_mode_ = false;
+    } else if (value == values::kIncognitoSplit) {
+      incognito_split_mode_ = true;
+    } else {
+      *error = errors::kInvalidIncognitoBehavior;
+      return false;
+    }
   // Although |source| is passed in as a const, it's still possible to modify
   // it.  This is dangerous since the utility process re-uses |source| after
   // it calls InitFromValue, passing it up to the browser process which calls
   // InitFromValue again.  As a result, we need to make sure that nobody
   // accidentally modifies it.
   DCHECK(source.Equals(manifest_value_.get()));
 
   return true;
 }
 
@@ skipping 280 matching lines @@
     : extension_id(id),
       extension_path(path),
       extension_location(location) {
   if (manifest)
     extension_manifest.reset(
         static_cast<DictionaryValue*>(manifest->DeepCopy()));
 }
 
 ExtensionInfo::~ExtensionInfo() {
 }