[GCM] Add app handler support for connection events

[GCM] Add app handler support for connection events

The OnConnected/OnDisconnected events are now plumbed through to app handlers
(and the default app handler). The App Handler has a default empty
implementation for those apps that don't care about exposing it. Additionally,
because an app might miss the first OnConnected event, an IsConnected method
is exposed by the GCMDriver that returns the last known connected status as
seen by the UI thread.

BUG=378536
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277200

[Nicolas Zea, 2014-06-09 23:02:07]

PTAL

[jianli, 2014-06-09 23:15:28]

lgtm

https://codereview.chromium.org/320993003/diff/60001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_desktop_unittest.cc (right):

https://codereview.chromium.org/320993003/diff/60001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_desktop_unittest.cc:325:
EXPECT_FALSE(driver()->IsStarted());
Could you please check driver()->IsConnected() and
gcm_app_handler()->connected() here?

[fgorski, 2014-06-09 23:19:43]

lgtm

https://codereview.chromium.org/320993003/diff/60001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_desktop.cc (right):

https://codereview.chromium.org/320993003/diff/60001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_desktop.cc:707:
GetAppHandler("")->OnConnected(ip_endpoint);
nit: could we add a constant for a default app handler... and drop the comment?

[Nicolas Zea, 2014-06-09 23:28:25]

+Pavel for gcm_invalidation_bridge

+Luigi FYI, see comment in default_gcm_app_handler

https://codereview.chromium.org/320993003/diff/60001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_desktop.cc (right):

https://codereview.chromium.org/320993003/diff/60001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_desktop.cc:707:
GetAppHandler("")->OnConnected(ip_endpoint);
On 2014/06/09 23:19:43, fgorski wrote:
> nit: could we add a constant for a default app handler... and drop the
comment?

Done.

https://codereview.chromium.org/320993003/diff/60001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_desktop_unittest.cc (right):

https://codereview.chromium.org/320993003/diff/60001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_desktop_unittest.cc:325:
EXPECT_FALSE(driver()->IsStarted());
On 2014/06/09 23:15:28, jianli wrote:
> Could you please check driver()->IsConnected() and
> gcm_app_handler()->connected() here?

Done.

[pavely, 2014-06-09 23:32:01]

gcm_invalidation_bridge lgtm

[Nicolas Zea, 2014-06-13 18:32:52]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2014-06-13 18:35:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zea@chromium.org/320993003/80001

[commit-bot: I haz the power, 2014-06-13 20:30:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/16688)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/19928)

[commit-bot: I haz the power, 2014-06-13 20:32:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 20:32:52]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/16745)

[Nicolas Zea, 2014-06-13 22:00:05]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2014-06-13 22:02:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zea@chromium.org/320993003/100001

[commit-bot: I haz the power, 2014-06-14 08:28:47]

Change committed as 277200