[NaCl SDK] nacl_io: Allows subtree of html5fs to be mounted.

native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/html5fs/html5_fs.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <stdlib.h>
 #include <string.h>
@@ skipping 24 matching lines @@
   return Open(path, O_RDONLY, &node);
 }
 
 Error Html5Fs::Open(const Path& path, int open_flags, ScopedNode* out_node) {
   out_node->reset(NULL);
   Error error = BlockUntilFilesystemOpen();
   if (error)
     return error;
 
   PP_Resource fileref = ppapi()->GetFileRefInterface()->Create(
-      filesystem_resource_, path.Join().c_str());
+      filesystem_resource_, GetFullPath(path).Join().c_str());
   if (!fileref)
     return ENOENT;
 
   ScopedNode node(new Html5FsNode(this, fileref));
   error = node->Init(open_flags);
   if (error)
     return error;
 
   *out_node = node;
   return 0;
 }
 
+Path Html5Fs::GetFullPath(const Path& path) {
+  Path full_path(path);
+  //if (!prefix_.empty())

[binji, 2014/06/09 20:54:29]

remove

[Sam Clegg, 2014/06/10 17:20:58]

Done.

+    full_path.Prepend(prefix_);
+  return full_path;
+}
+
 Error Html5Fs::Unlink(const Path& path) {
-  return Remove(path);
+  return RemoveInternal(path, REMOVE_FILE);
 }
 
 Error Html5Fs::Mkdir(const Path& path, int permissions) {
   Error error = BlockUntilFilesystemOpen();
   if (error)
     return error;
 
   // FileRef returns PP_ERROR_NOACCESS which is translated to EACCES if you
   // try to create the root directory. EEXIST is a better errno here.
   if (path.Top())
     return EEXIST;
 
   ScopedResource fileref_resource(
       ppapi(),
       ppapi()->GetFileRefInterface()->Create(filesystem_resource_,
-                                             path.Join().c_str()));
+                                             GetFullPath(path).Join().c_str()));
   if (!fileref_resource.pp_resource())
     return ENOENT;
 
   int32_t result = ppapi()->GetFileRefInterface()->MakeDirectory(
       fileref_resource.pp_resource(), PP_FALSE, PP_BlockUntilComplete());
   if (result != PP_OK)
     return PPErrorToErrno(result);
 
   return 0;
 }
 
 Error Html5Fs::Rmdir(const Path& path) {
-  return Remove(path);
+  return RemoveInternal(path, REMOVE_DIR);
 }
 
 Error Html5Fs::Remove(const Path& path) {
+  return RemoveInternal(path, REMOVE_ALL);
+}
+
+Error Html5Fs::RemoveInternal(const Path& path, int remove_type) {
   Error error = BlockUntilFilesystemOpen();
   if (error)
     return error;
 
   ScopedResource fileref_resource(
       ppapi(),
       ppapi()->GetFileRefInterface()->Create(filesystem_resource_,
-                                             path.Join().c_str()));
+                                             GetFullPath(path).Join().c_str()));
   if (!fileref_resource.pp_resource())
     return ENOENT;
 
+  // Check file type
+  if (remove_type != REMOVE_ALL) {
+    PP_FileInfo file_info;
+    int32_t query_result = ppapi()->GetFileRefInterface()->Query(
+        fileref_resource.pp_resource(), &file_info, PP_BlockUntilComplete());
+    if (query_result != PP_OK) {
+      LOG_ERROR("Error querying file type");
+      return EINVAL;
+    }
+    switch (file_info.type) {
+      case PP_FILETYPE_DIRECTORY:
+        if (!(remove_type & REMOVE_DIR))
+          return EISDIR;
+        break;
+      case PP_FILETYPE_REGULAR:
+        if (!(remove_type & REMOVE_FILE))
+          return ENOTDIR;
+        break;
+      default:
+        LOG_ERROR("Invalid file type: %d", file_info.type);
+        return EINVAL;
+    }
+  }
+
   int32_t result = ppapi()->GetFileRefInterface()->Delete(
       fileref_resource.pp_resource(), PP_BlockUntilComplete());
   if (result != PP_OK)
     return PPErrorToErrno(result);
 
   return 0;
 }
 
 Error Html5Fs::Rename(const Path& path, const Path& newpath) {
   Error error = BlockUntilFilesystemOpen();
   if (error)
     return error;
 
+  const char* oldpath_full = GetFullPath(path).Join().c_str();
   ScopedResource fileref_resource(
       ppapi(),
       ppapi()->GetFileRefInterface()->Create(filesystem_resource_,
-                                             path.Join().c_str()));
+                                             oldpath_full));

[binji, 2014/06/09 20:54:29]

do these fit on the previous line now?

[Sam Clegg, 2014/06/10 17:20:58]

Nope :(

   if (!fileref_resource.pp_resource())
     return ENOENT;
 
+  const char* newpath_full = GetFullPath(newpath).Join().c_str();
   ScopedResource new_fileref_resource(
       ppapi(),
       ppapi()->GetFileRefInterface()->Create(filesystem_resource_,
-                                             newpath.Join().c_str()));
+                                             newpath_full));
   if (!new_fileref_resource.pp_resource())
     return ENOENT;
 
   int32_t result =
       ppapi()->GetFileRefInterface()->Rename(fileref_resource.pp_resource(),
                                              new_fileref_resource.pp_resource(),
                                              PP_BlockUntilComplete());
   if (result != PP_OK)
     return PPErrorToErrno(result);
 
@@ skipping 20 matching lines @@
   PP_FileSystemType filesystem_type = PP_FILESYSTEMTYPE_LOCALPERSISTENT;
   int64_t expected_size = 0;
   for (StringMap_t::const_iterator iter = args.string_map.begin();
        iter != args.string_map.end();
        ++iter) {
     if (iter->first == "type") {
       if (iter->second == "PERSISTENT") {
         filesystem_type = PP_FILESYSTEMTYPE_LOCALPERSISTENT;
       } else if (iter->second == "TEMPORARY") {
         filesystem_type = PP_FILESYSTEMTYPE_LOCALTEMPORARY;
+      } else if (iter->second == "") {

[binji, 2014/06/09 20:54:29]

why allow this? The default is LOCALPERSISTENT

[Sam Clegg, 2014/06/10 17:20:58]

The unit tests rely on this.. maybe I should change them?

[binji, 2014/06/10 18:00:58]

I'd prefer it, it seems weird to add support for an empty type here.

+        filesystem_type = PP_FILESYSTEMTYPE_LOCALPERSISTENT;
+      } else {
+        LOG_ERROR("html5fs: unknown type: '%s'", iter->second.c_str());
+        return EINVAL;
       }
     } else if (iter->first == "expected_size") {
       expected_size = strtoull(iter->second.c_str(), NULL, 10);
     } else if (iter->first == "filesystem_resource") {
       PP_Resource resource = strtoull(iter->second.c_str(), NULL, 10);
       if (!ppapi_->GetFileSystemInterface()->IsFileSystem(resource))
         return EINVAL;
 
       filesystem_resource_ = resource;
       ppapi_->AddRefResource(filesystem_resource_);
+    } else if (iter->first == "SOURCE") {
+      prefix_ = iter->second;
+    } else {
+      LOG_ERROR("html5fs: bad param: %s", iter->first.c_str());
+      return EINVAL;
     }
   }
 
   if (filesystem_resource_ != 0) {
     filesystem_open_has_result_ = true;
     filesystem_open_error_ = PP_OK;
     return 0;
   }
 
   // Initialize filesystem.
@@ skipping 46 matching lines @@
 }
 
 void Html5Fs::FilesystemOpenCallback(int32_t result) {
   AUTO_LOCK(filesysem_open_lock_);
   filesystem_open_has_result_ = true;
   filesystem_open_error_ = PPErrorToErrno(result);
   pthread_cond_signal(&filesystem_open_cond_);
 }
 
 }  // namespace nacl_io