Issue 320953002: Timeline: split frame model into trace-specific and record-specific parts

Issue 320953002: Timeline: split frame model into trace-specific and record-specific parts (Closed)

Created:
6 years, 6 months ago by caseq

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: split frame model into trace-specific and record-specific parts Just moving things around, no actualy logic change, though dropped unused FrameAdded event. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175881

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased and removed extra semicolon #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+249 lines, -216 lines)			Patch
M	LayoutTests/inspector/timeline/tracing/frame-model.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFrameModel.js	View	1	5 chunks	+230 lines, -202 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFrameOverview.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePanel.js	View		2 chunks	+13 lines, -8 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineView.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/320953002/diff/1/Source/devtools/front_end/timeline/TimelineFrameModel.js File Source/devtools/front_end/timeline/TimelineFrameModel.js (right): https://codereview.chromium.org/320953002/diff/1/Source/devtools/front_end/timeline/TimelineFrameModel.js#newcode469 Source/devtools/front_end/timeline/TimelineFrameModel.js:469: }; style: please remove ; https://codereview.chromium.org/320953002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js ...

6 years, 6 months ago (2014-06-10 07:56:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/320953002/20001

6 years, 6 months ago (2014-06-10 09:04:26 UTC) #4

Message was sent while issue was closed.

Change committed as 175881

Expand Messages | Collapse Messages